Removed Session.__del__ and added harsh deletion test

neo4j · Mar 18, 2016 · f1350ad · f1350ad
1 parent 126060f
commit f1350ad
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 7 deletions.
diff --git a/neo4j/v1/session.py b/neo4j/v1/session.py
@@ -418,13 +418,6 @@ def __init__(self, driver):
         self.transaction = None
         self.last_result = None
 
-    def __del__(self):
-        try:
-            if not self.connection.closed:
-                self.connection.close()
-        except AttributeError:
-            pass
-
     def __enter__(self):
         return self
 

diff --git a/test/test_session.py b/test/test_session.py
@@ -554,6 +554,16 @@ def test_can_consume_result_after_session_reuse(self):
         assert [record[0] for record in result_a] == [1, 2, 3]
         assert [record[0] for record in result_b] == [4, 5, 6]
 
+    def test_can_consume_results_after_harsh_session_death(self):
+        session = self.driver.session()
+        result_a = session.run("UNWIND range(1, 3) AS n RETURN n")
+        del session
+        session = self.driver.session()
+        result_b = session.run("UNWIND range(4, 6) AS n RETURN n")
+        del session
+        assert [record[0] for record in result_a] == [1, 2, 3]
+        assert [record[0] for record in result_b] == [4, 5, 6]
+
     def test_can_consume_result_after_session_with_error(self):
         session = self.driver.session()
         with self.assertRaises(CypherError):