add Netty leak detector extension

neo4j · Mar 25, 2024 · 9a927ca · 9a927ca
1 parent 2db210a
commit 9a927ca
Show file tree

Hide file tree

Showing 4 changed files with 17 additions and 0 deletions.
diff --git a/driver/pom.xml b/driver/pom.xml
@@ -106,6 +106,11 @@
       <artifactId>neo4j</artifactId>
       <scope>test</scope>
     </dependency>
+    <dependency>
+      <groupId>io.github.nettyplus</groupId>
+      <artifactId>netty-leak-detector-junit-extension</artifactId>
+      <scope>test</scope>
+    </dependency>
     <dependency>
       <groupId>commons-codec</groupId>
       <artifactId>commons-codec</artifactId>

diff --git a/driver/src/test/java/org/neo4j/driver/integration/TransactionIT.java b/driver/src/test/java/org/neo4j/driver/integration/TransactionIT.java
@@ -29,12 +29,14 @@
 import static org.neo4j.driver.internal.logging.DevNullLogging.DEV_NULL_LOGGING;
 import static org.neo4j.driver.testutil.TestUtil.assertNoCircularReferences;
 
+import io.github.nettyplus.leakdetector.junit.NettyLeakDetectorExtension;
 import java.time.Clock;
 import java.util.List;
 import java.util.Map;
 import java.util.function.Consumer;
 import java.util.stream.LongStream;
 import org.junit.jupiter.api.Test;
+import org.junit.jupiter.api.extension.ExtendWith;
 import org.junit.jupiter.api.extension.RegisterExtension;
 import org.junit.jupiter.params.ParameterizedTest;
 import org.junit.jupiter.params.provider.ValueSource;
@@ -53,6 +55,7 @@
 import org.neo4j.driver.testutil.TestUtil;
 
 @ParallelizableIT
+@ExtendWith(NettyLeakDetectorExtension.class)
 class TransactionIT {
     @RegisterExtension
     static final SessionExtension session = new SessionExtension();

diff --git a/driver/src/test/java/org/neo4j/driver/integration/async/AsyncTransactionIT.java b/driver/src/test/java/org/neo4j/driver/integration/async/AsyncTransactionIT.java
@@ -38,6 +38,7 @@
 import static org.neo4j.driver.testutil.TestUtil.assertNoCircularReferences;
 import static org.neo4j.driver.testutil.TestUtil.await;
 
+import io.github.nettyplus.leakdetector.junit.NettyLeakDetectorExtension;
 import java.io.IOException;
 import java.util.Arrays;
 import java.util.Collections;
@@ -48,6 +49,7 @@
 import org.junit.jupiter.api.AfterEach;
 import org.junit.jupiter.api.BeforeEach;
 import org.junit.jupiter.api.Test;
+import org.junit.jupiter.api.extension.ExtendWith;
 import org.junit.jupiter.api.extension.RegisterExtension;
 import org.neo4j.driver.Query;
 import org.neo4j.driver.async.AsyncSession;
@@ -60,6 +62,7 @@
 import org.neo4j.driver.testutil.ParallelizableIT;
 
 @ParallelizableIT
+@ExtendWith(NettyLeakDetectorExtension.class)
 class AsyncTransactionIT {
     @RegisterExtension
     static final DatabaseExtension neo4j = new DatabaseExtension();

diff --git a/pom.xml b/pom.xml
@@ -45,6 +45,7 @@
     <hamcrest.version>2.2</hamcrest.version>
     <mockito-core.version>5.8.0</mockito-core.version>
     <junit.version>5.10.2</junit.version>
+    <netty-leak-detector.version>0.0.4</netty-leak-detector.version>
     <!-- supply a newer version than the one supplied by the reactive-streams 1.0.4 -->
     <testng.version>7.9.0</testng.version>
     <jarchivelib.version>1.2.0</jarchivelib.version>
@@ -219,6 +220,11 @@
         <type>pom</type>
         <scope>import</scope>
       </dependency>
+      <dependency>
+        <groupId>io.github.nettyplus</groupId>
+        <artifactId>netty-leak-detector-junit-extension</artifactId>
+        <version>${netty-leak-detector.version}</version>
+      </dependency>
 
       <!-- Testkit Backend Dependencies -->
       <dependency>