[Fix]: keyPrefix in DataCache.Find can be all 0xff.
#3681
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shargon
reviewed
Jan 20, 2025
| action.Should().Throw<ArgumentException>(); | ||
| action = () => myDataCache.Find(new byte[] { }, SeekDirection.Backward); | ||
| action.Should().Throw<ArgumentException>(); | ||
| // Action action = () => myDataCache.Find(null, SeekDirection.Backward); |
There was a problem hiding this comment.
Better adjust the logic instead of comment it
nan01ab
force-pushed
the
fix.DataCache-Find-keyPrefix
branch
from
b8b9481 to
06cd75c
Compare
nan01ab
changed the title
Fix]: keyPrefix in DataCache.Find can be null, empty, or all 0xff.Fix]: keyPrefix in DataCache.Find can be all 0xff.
nan01ab
commented
Jan 20, 2025
| { | ||
| throw new ArgumentException($"{nameof(key_prefix)} with all bytes being 0xff is not supported now"); | ||
| // This case is rare | ||
| seekPrefix = new byte[ApplicationEngine.MaxStorageKeySize + 1]; |
There was a problem hiding this comment.
MaxStorageKeySize.
Maybe not long enough.
Jim8y
reviewed
Jan 21, 2025
| throw new ArgumentException($"{nameof(key_prefix)} with all bytes being 0xff is not supported now"); | ||
| // This case is rare | ||
| seekPrefix = new byte[ApplicationEngine.MaxStorageKeySize + 1]; | ||
| Array.Fill(seekPrefix, (byte)0xff); |
There was a problem hiding this comment.
is this a logic change @shargon?
There was a problem hiding this comment.
I think it doesn't matter.
Closed
13 tasks
|
A better fix #3688 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
DataCache.Find(keyPrefix, SeekDirection.Forward)start from the first key if keyPrefix is null or empty.But
DataCache.Find(keyPrefix, SeekDirection.Backword)throws an Exception.It's better to keep a similar logic with different
SeekDirection.Allow all 0xff
keyPrefix.This PR depends on #3680
Type of change
Checklist: