[Fix] Leveldb RocksDb Runtime Binaries

[cschuchardt88]

Description

Deploys the runtime binaries for neo-cli. So developer don't have to copy the plugins and its deps.

Enabled leveldb to run tests on all OSS.

• Local Development
• Github Release
• Github workflow tests for all OS, windows, linux, macos
• github docker release
• dev containers
• dotnet publish, build

Type of change

• Optimization (the change is only an optimization)
• Style (the change is only a code style for better maintenance or standard purpose)
• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)
• This change requires a documentation update

How Has This Been Tested?

• Locally
• My Github Repo

Checklist:

• My code follows the style guidelines of this project
• I have performed a self-review of my code
• I have commented my code, particularly in hard-to-understand areas
• I have made corresponding changes to the documentation
• My changes generate no new warnings
• I have added tests that prove my fix is effective or that my feature works
• New and existing unit tests pass locally with my changes
• Any dependent changes have been merged and published in downstream modules

[vncoelho]

I am not sure, we discussed that in a meeting.
I am not in agreement yet.

[Jim8y]

I am with this pr, when NGD release the cli, it uses ngd-leveldb, so it should be considered a valid way of getting leveldb by downloading it from NGD.

[vncoelho]

Maybe just this part is good for now, @cschuchardt88 .
If so we close the other PR I opened.

[vncoelho]

If you want to open this separately, because the rest of the PR, for now, I am not in agreement.

[cschuchardt88]

Can you specify what you do not like with this PR? So maybe we can work on fixing it or answering any concerns or reasons you have.

[cschuchardt88]

I am with this pr, when NGD release the cli, it uses ngd-leveldb, so it should be considered a valid way of getting leveldb by downloading it from NGD.

We even have neo-cli send the end user to NGD github page to download leveldb.

[shargon]

If we need a new dependency for example, in oracle, we will do the same? For me this is not a fix, it's a bypass

[cschuchardt88]

If we need a new dependency for example, in oracle, we will do the same? For me this is not a fix, it's a bypass

How is it not a fix, nothing is being bypassed. Im working with what i got here. So give me some slack. All I do is make problems go away. All the issues with the leveldb and rocksdb is gone. There is no new dependency.

[shargon]

@superboyiii could you test it?

[superboyiii]

@superboyiii could you test it?

Sure

[cschuchardt88]

@superboyiii could you test it?

Sure

@superboyiii
Also test the github workflows, to make sure the builds are correct when they run for release.

[cschuchardt88]

https://learn.microsoft.com/en-us/nuget/create-packages/native-files-in-net-packages#putting-it-together

[superboyiii]

@cschuchardt88
Issue 1: Release on my repo by the workflows, but can't run CLI on windows correctly. Haven't tried the others.
PS: I find you forgot to copy leveldb.dll into that package. It can work now with leveldb installed.

Issue 2: Build CLI by myself, but it can't connect to others. It can only sync offline package. What a single player CLI:)
This issue is not from this PR, it can also be replayed on master branch. I reported it in #3694

[cschuchardt88]

@superboyiii File is in the runtimes folder. dotnet should of picked up the dll in that folder. But ill look into it.

[cschuchardt88]

@superboyiii All fixed now.

Also don't forget to test the docker image that we will be releasing too.

It is located here https://github.com/superboyiii/neo/pkgs/container/neo-cli (created on release)