-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Neo Plugin UT] Rpcserver unit test on node #3353
Merged
Merged
Changes from 28 commits
Commits
Show all changes
33 commits
Select commit
Hold shift + click to select a range
d1eab9a
try mock
Jim8y 9b238ec
Merge branch 'master' into mock-rpcserver-test
Jim8y dff3c79
not use mock
Jim8y cb5c875
test
Jim8y cccab76
fix test
Jim8y ef6b001
use neo testutils
Jim8y 3c43399
complete rpcserver blockchain tests.
Jim8y 0c90df1
revert change to ByteArrayComparer
Jim8y bee3102
revert cache change
Jim8y a674ec7
add more detail to comments
Jim8y cdc2b41
add more exception test cases
Jim8y a58e05f
fix warning
Jim8y 02f3264
Apply suggestions from code review
shargon d8b67b3
update TODO mark
Jim8y b5d5bfd
Merge branch 'mock-rpcserver-test' of github.com:Jim8y/neo into mock-…
Jim8y 98beb3d
Merge branch 'master' into mock-rpcserver-test
Jim8y a4c7638
add node rpc tests
Jim8y 1b92a11
Merge branch 'master' into rpcserver_test_node
Jim8y 92858b2
fix build error
Jim8y 5a1918e
Merge branch 'master' into rpcserver_test_node
Jim8y d39b9dc
set the mempool to 5.
Jim8y 0a43d30
Merge branch 'rpcserver_test_node' of github.com:Jim8y/neo into rpcse…
Jim8y 3e91a32
remove memory pool test.
Jim8y d1a0058
Merge branch 'master' into rpcserver_test_node
Jim8y 46c0216
fix tests
Jim8y d8bc36a
fix test issue
Jim8y 4f19409
Merge branch 'master' into rpcserver_test_node
shargon 4841d19
Update tests/Neo.UnitTests/TestUtils.Transaction.cs
shargon 38724a7
Merge branch 'master' into rpcserver_test_node
shargon c4f4e0b
Merge branch 'master' into rpcserver_test_node
Jim8y b52b81f
Merge branch 'master' into rpcserver_test_node
NGDAdmin e092c65
Merge branch 'master' into rpcserver_test_node
NGDAdmin 1a52f19
Merge branch 'master' into rpcserver_test_node
NGDAdmin File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it doesn't hurt without debug, it's already internal, but it's ok for me
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we compile in release maybe it fault because the UT require this method
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Then add to test the same way as
#if DEBUG
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Jim8y we need to compile the whole sln in release, I think it won't work with this change