-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Neo Plugin Fix] Fix targes #3343
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Whats the problem with the Targets
?
Reason for so we can do Standard
or any other target in feature. Unless you have a problem coming up, than I dont see the point.
This PR breaks github actions and building environment.
Why you approving something is breaks our environment. everyone's inexperienced or lack of knowledge of dotnet is disappointing when the issue is just that. This break tests and other things in your our
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Doesnt work in all enviroments, breaks testing and github workflows, along with local development and other frameworks
like dotnet standard
.
Because we build for |
Close as #3343 (comment) |
Description
This pr fixes the issue of multiple targes for plugins while there is only one target specified. Making it impossible for dotnet publish to automatically detect the target.
Fixes # #3344
Type of change
How Has This Been Tested?
Test Configuration:
Checklist: