Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: some compiler warnings #1288

Merged
merged 3 commits into from
Feb 1, 2025
Merged

Fix: some compiler warnings #1288

merged 3 commits into from
Feb 1, 2025

Conversation

nan01ab
Copy link
Contributor

@nan01ab nan01ab commented Jan 30, 2025 •
edited
Loading

Fix some compiler warnings.

These shouldn't be null.

@Jim8y Jim8y merged commit 4c939f9 into neo-project:master Feb 1, 2025
4 checks passed
@Jim8y Jim8y deleted the fix.remove-some-compiler-warnings branch February 1, 2025 15:53
Jim8y added a commit that referenced this pull request Feb 5, 2025
@Jim8y
Merge branch 'master' into test-optimizer
07b0260 
* master:
  fix: always check division overflow for int32 and int64 (#1287)
  Fix: some compiler warnings (#1288)
  use INC DEC (#1286)
  Update neo (#1285)
  Update: keep same sdk version with 'neo' (#1284)
  partially fix return in try; optimizer replaces JMP->ENDTRY with only ENDTRY (#1283)
  update to dotnet 9 (#1257)
  Added some styles (#1280)
  [`Fix`]: `checked(-x)` if x is int or long (#1281)
  Fix continue and goto (#1282)

# Conflicts:
#	tests/Neo.Compiler.CSharp.UnitTests/TestingArtifacts/Contract_Types_BigInteger.cs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shargon shargon shargon approved these changes

@Jim8y Jim8y Jim8y approved these changes

@vncoelho vncoelho vncoelho approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@nan01ab @shargon @Jim8y @vncoelho