Change default printing options in __main__ (tests). #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changes the default numpy 2 printing options that crash doctests on scalars.
Sometime tests fail due to too strict tolerance. Change 1e-12 to 1e-11.
|
Sounds good for me, thanks for the modification ;-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Numpy 2.0 change the default printing options
see https://numpy.org/neps/nep-0051-scalar-representation.html
This change crash doctests on scalars. For instance:
legacy:
New style:
This PR propose to use
Only in the test runner file, here
__main__.py.Perhaps we could change the format in doctest when numpy 2 will be more common.
I also change the tol in
_fpolydoctest which was sometimes too strict.