-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Hotfix] solution for issue with v1.8.7
#106
Conversation
To test this without having to wait for ever set the test timeout to 60s by adding `-timeout 60s` on the command line.
Thanks for the fix. Having roughly the same code repeated for the different |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, see specific comment about stream position and return.
The root caouse was that we didn't signal EOF once we read everything. Kudos to Pontus that actually figured it out. Co-authored-by: Pontus Freyhult <[email protected]>
7541e61
to
65b1a14
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #106 +/- ##
==========================================
+ Coverage 66.29% 66.46% +0.17%
==========================================
Files 6 6
Lines 1178 1184 +6
==========================================
+ Hits 781 787 +6
Misses 278 278
Partials 119 119
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
v1.8.7
introduced a bug where decryption would deadlock if the available read buffer was 0. Causing the stream to read the same byte over and over again and never reaching the end of the file.This PR fixes the issue found in 1.8.7 and adds a decryption test for decrypting an entire file.