-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Configuration Improvement: Create config.toml
on Application Start
#363
Conversation
8d1ad71
to
b14b5e4
Compare
config.toml
on Application Start
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall looks great. I left few comments where this PR might be improved. Appreciate your contribution ❤️
@race-of-sloths please, include my PR in the Race |
@kobayurii Thank you for your contribution! Your pull request is now a part of the Race of Sloths! Current status: executed
Your contribution is much appreciated with a final score of 2! What is the Race of SlothsRace of Sloths is a friendly competition where you can participate in challenges and compete with other open-source contributors within your normal workflow For contributors:
For maintainers:
Feel free to check our website for additional details! Bot commands
|
db32908
to
b968a38
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, can you please update the CHANGELOG with this change and we're ready to merge
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry I missed that you've made the record in the CHANGELOG. Perfect!
🥁 Score it! @khorolets, please score the PR with |
This PR introduces a feature to automatically create a default
config.toml
file when the application starts, ensuring that configuration parameters are loaded from environment variables. If aconfig.toml
is not found, the application will generate one using the environment variables.Details:
config.toml
file if it does not already exist.config.toml
will include parameters from the environment variables.Purpose:
This improvement aims to simplify the configuration process and provide better visibility into the parameters being used by the application. By generating a default
config.toml
, users can easily adjust configurations without needing to manually create this file.