Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configuration Improvement: Create config.toml on Application Start #363

Merged
merged 6 commits into from
Oct 17, 2024

Conversation

kobayurii
Copy link
Member

@kobayurii kobayurii commented Oct 16, 2024

This PR introduces a feature to automatically create a default config.toml file when the application starts, ensuring that configuration parameters are loaded from environment variables. If a config.toml is not found, the application will generate one using the environment variables.

Details:

  • Adds functionality to create a default config.toml file if it does not already exist.
  • The generated config.toml will include parameters from the environment variables.
  • Any environment variables not set will be assigned default values.

Purpose:
This improvement aims to simplify the configuration process and provide better visibility into the parameters being used by the application. By generating a default config.toml, users can easily adjust configurations without needing to manually create this file.

@kobayurii kobayurii requested a review from khorolets October 16, 2024 08:55
@kobayurii kobayurii self-assigned this Oct 16, 2024
@kobayurii kobayurii changed the title Config improvement Configuration Improvement: Create config.toml on Application Start Oct 16, 2024
Copy link
Member

@khorolets khorolets left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks great. I left few comments where this PR might be improved. Appreciate your contribution ❤️

configuration/src/default_env_configs.rs Outdated Show resolved Hide resolved
configuration/src/lib.rs Outdated Show resolved Hide resolved
@kobayurii
Copy link
Member Author

@race-of-sloths please, include my PR in the Race

@kobayurii kobayurii marked this pull request as ready for review October 16, 2024 10:33
@race-of-sloths
Copy link

race-of-sloths commented Oct 16, 2024

@kobayurii Thank you for your contribution! Your pull request is now a part of the Race of Sloths!
Weekly streak is on the road, smart strategy! Secure your streak with another PR!

Shows inviting banner with latest news.

Shows profile picture for the author of the PR

Current status: executed
Reviewer Score
@race-of-sloths 2

Your contribution is much appreciated with a final score of 2!
You have received 21 (20 base + 5% lifetime bonus) Sloth points for this contribution

What is the Race of Sloths

Race of Sloths is a friendly competition where you can participate in challenges and compete with other open-source contributors within your normal workflow

For contributors:

  • Tag @race-of-sloths inside your pull requests
  • Wait for the maintainer to review and score your pull request
  • Check out your position in the Leaderboard
  • Keep weekly and monthly streaks to reach higher positions
  • Boast your contributions with a dynamic picture of your Profile

For maintainers:

  • Score pull requests that participate in the Race of Sloths
  • Engage contributors with fair scoring and fast responses so they keep their streaks
  • Promote the Race to the point where the Race starts promoting you
  • Grow the community of your contributors

Feel free to check our website for additional details!

Bot commands
  • For contributors
    • Include a PR: @race-of-sloths include to enter the Race with your PR
  • For maintainers:
    • Invite contributor @race-of-sloths invite to invite the contributor to participate in a race or include it, if it's already a runner.
    • Assign points: @race-of-sloths score [1/2/3/5/8/13] to award points based on your assessment.
    • Reject this PR: @race-of-sloths exclude to send this PR back to the drawing board.
    • Exclude repo: @race-of-sloths pause to stop bot activity in this repo until @race-of-sloths unpause command is called

@kobayurii kobayurii requested a review from khorolets October 16, 2024 10:47
Copy link
Member

@khorolets khorolets left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, can you please update the CHANGELOG with this change and we're ready to merge

Copy link
Member

@khorolets khorolets left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry I missed that you've made the record in the CHANGELOG. Perfect!

@kobayurii kobayurii merged commit 6adbf03 into develop Oct 17, 2024
3 checks passed
@race-of-sloths
Copy link

🥁 Score it!

@khorolets, please score the PR with @race-of-sloths score [1/2/3/5/8/13]. The contributor deserves it.
If no scoring is provided within 24 hours, this PR will be scored as 2 🦥

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants