Implement TOML Configuration for All Services #152
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kobayurii
force-pushed
the
config
branch
3 times, most recently
from
a5320f7 to
9c11bd3
Compare
kobayurii
force-pushed
the
config
branch
3 times, most recently
from
ea0be28 to
3cad8f0
Compare
kobayurii
force-pushed
the
config
branch
2 times, most recently
from
eecfd30 to
b14fd10
Compare
khorolets
reviewed
Jan 8, 2024
kobayurii
force-pushed
the
config
branch
2 times, most recently
from
16ea182 to
28a5f32
Compare
kobayurii
changed the title
kobayurii
force-pushed
the
config
branch
2 times, most recently
from
893953b to
c422c91
Compare
khorolets
requested changes
Jan 29, 2024
add config.toml around env variables fix docker build
kobayurii
force-pushed
the
config
branch
3 times, most recently
from
934ce05 to
090dcc4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces a comprehensive implementation of TOML configuration for all services within the project.
The primary goal is to enhance configurability, ease of maintenance, and flexibility across various components.
The changes included in this pull request are outlined below:
Introduces TOML configuration file for all services.
Adopts TOML syntax for configuration file, providing a clear and human-readable format for specifying settings.
Defines services-specific settings in the configuration file.
Centralized configuration offers flexibility management for all services.
The configuration file supports the use of ENV variables, which greatly extends the possibilities.
Implements validation mechanisms to ensure that configuration files adhere to the expected structure and contain valid values. Introduces error handling for scenarios where configuration values are missing or incorrect.
For developers who want to operate the ReadRPC node for their own needs.
This PR includes serving the data related to specific contracts, which actsas a backend for applications.
The configuration provides opportunities not to serve all the archival data.
This pull request aims to enhance the maintainability and configurability of the project by adopting a standardized TOML configuration approach.