feat(optimistic_block): produce #12761
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VanBarbascu
requested review from
Longarithm
and removed request for
saketh-are
Longarithm
approved these changes
Jan 20, 2025
There was a problem hiding this comment.
Very nice! I think it can be merged after merging with master. Leaving mostly nits.
We can start thinking if something can already be unit-tested here. Maybe just run produce_optimistic, then produce and check that timestamps match. But it can be done later, and if setup is too hard, we'd have to make it simple first.
VanBarbascu
force-pushed
the
optimistic_block/create
branch
from
492e6e3 to
66b73c5
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #12761 +/- ##
========================================
Coverage 70.51% 70.52%
========================================
Files 846 846
Lines 174633 174782 +149
Branches 174633 174782 +149
========================================
+ Hits 123149 123262 +113
- Misses 46254 46276 +22
- Partials 5230 5244 +14
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
VanBarbascu
force-pushed
the
optimistic_block/create
branch
3 times, most recently
from
64000a7 to
1c75f16
Compare
Co-authored-by: Aleksandr Logunov <[email protected]>
VanBarbascu
force-pushed
the
optimistic_block/create
branch
from
619074f to
276b198
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We continue the implementation of Optimistic block #10584, by adding the logic to produce the block as soon as the previous block is done.
If available, the optimistic block will be used in the production of the block to use the same timestamp.