fix(forknet): Fix the state parts bucket cleanup logic

[VanBarbascu]

Allow reset command to run without --gcs... parameter.

mirror reset --backup-id start --yes        
Traceback (most recent call last):                                                                                                                                                                                  
  File "/Users/razvan/repos/nearcore/pytest/tests/mocknet/mirror.py", line 772, in <module>                                                                                                                         
    args.func(args, traffic_generator, wanted_nodes)                                                      
  File "/Users/razvan/repos/nearcore/pytest/tests/mocknet/mirror.py", line 381, in reset_cmd
    _clear_state_parts_if_exists(_get_state_parts_location(args), nodes)
                                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^                                          
  File "/Users/razvan/repos/nearcore/pytest/tests/mocknet/mirror.py", line 280, in _get_state_parts_location
    if args.gcs_state_sync:                                                                               
       ^^^^^^^^^^^^^^^^^^^                       
AttributeError: 'Namespace' object has no attribute 'gcs_state_sync'

[VanBarbascu]

Python complains about the \* as it tries to parse it as an escape sequence. It should be safe to pass it here without escaping it.

[Trisfald]

Why did you move this block to line 247?

[VanBarbascu]

In this function _clear_state_parts_if_exists, we want to check if the state parts exist and then clear them.

Previously, we assumed that if we are in a localtest, we always dump the parts, but is not the case.
With this change, we will make it clear to the mirror.py user if the parts were deleted or not.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.63%. Comparing base (f9e403b) to head (01789f1).
Report is 2 commits behind head on master.

Additional details and impacted files

@@            Coverage Diff             @@
##           master   #12712      +/-   ##
==========================================
- Coverage   70.64%   70.63%   -0.01%     
==========================================
  Files         848      848              
  Lines      173732   173730       -2     
  Branches   173732   173730       -2     
==========================================
- Hits       122725   122713      -12     
- Misses      45875    45883       +8     
- Partials     5132     5134       +2     

Flag	Coverage Δ
backward-compatibility	0.16% <ø> (ø)
db-migration	0.16% <ø> (ø)
genesis-check	1.36% <ø> (+<0.01%)	⬆️
linux	69.23% <ø> (+0.01%)	⬆️
linux-nightly	70.23% <ø> (+<0.01%)	⬆️
pytests	1.66% <ø> (+<0.01%)	⬆️
sanity-checks	1.47% <ø> (+<0.01%)	⬆️
unittests	70.46% <ø> (-0.01%)	⬇️
upgradability	0.20% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[Trisfald]

LGTM