feat: improved error reporting for near macro

[akorchyn]

This PR intends to clarify errors for the user. This PR doesn't introduce new errors, but rather clarifies them. As older compilation errors are hard to understand

• Added a new error message if the near(contract_state) was used two times in the same crate.
• Added a new error message if there is a nested near macro

Messages before:

Contract state repetion:

error: symbol `__near_abi_contract_source_metadata` is already defined
 --> compilation_tests/double_contract_state_error.rs:9:5
  |
9 |     #[near(contract_state)]

Near macro nesting:

error: multiple `borsh` attributes not allowed
  --> compilation_tests/nested_near_error.rs:6:1
   |
6  | / #[near(contract_metadata(
7  | |     version = "39f2d2646f2f60e18ab53337501370dc02a5661c",
8  | |     link = "https://github.com/near-examples/nft-tutorial",
9  | |     standard(standard = "nep171", version = "1.0.0"),
10 | |     standard(standard = "nep177", version = "2.0.0"),
11 | | ))]
   | |___^
   |
   = note: this error originates in the attribute macro `near` (in Nightly builds, run with -Z macro-backtrace for more info)

[dj8yfo]

@race-of-sloths score 8

[race-of-sloths]

@akorchyn Thank you for your contribution! Your pull request is now a part of the Race of Sloths!
Are you going to win race-of-sloths this month? If so, you should speed up! Run, Sloth, run!

Current status: executed

Reviewer	Score
@dj8yfo	8

Your contribution is much appreciated with a final score of 8!
You have received 88 (80 base + 10% lifetime bonus) Sloth points for this contribution

@dj8yfo received 25 Sloth Points for reviewing and scoring this pull request.

What is the Race of Sloths

Race of Sloths is a friendly competition where you can participate in challenges and compete with other open-source contributors within your normal workflow

For contributors:

• Tag @race-of-sloths inside your pull requests
• Wait for the maintainer to review and score your pull request
• Check out your position in the Leaderboard
• Keep weekly and monthly streaks to reach higher positions
• Boast your contributions with a dynamic picture of your Profile

For maintainers:

• Score pull requests that participate in the Race of Sloths and receive a reward
• Engage contributors with fair scoring and fast responses so they keep their streaks
• Promote the Race to the point where the Race starts promoting you
• Grow the community of your contributors

Feel free to check our website for additional details!

Bot commands

• For contributors
  • Include a PR: @race-of-sloths include to enter the Race with your PR
• For maintainers:
  • Invite contributor @race-of-sloths invite to invite the contributor to participate in a race or include it, if it's already a runner.
  • Assign points: @race-of-sloths score [1/2/3/5/8/13] to award points based on your assessment.
  • Reject this PR: @race-of-sloths exclude to send this PR back to the drawing board.
  • Exclude repo: @race-of-sloths pause to stop bot activity in this repo until @race-of-sloths unpause command is called

[dj8yfo]

TODO: test this patch with neardevhub-contract (repo, a few contracts therein)

neardevhub-contract should be a goto place to check if unsure if stuff's gonna break unexpectedly

[codecov]

Codecov Report

Attention: Patch coverage is 43.24324% with 21 lines in your changes missing coverage. Please review.

Project coverage is 80.06%. Comparing base (5ddafdc) to head (2bd96ad).
Report is 1 commits behind head on master.

Files with missing lines	Patch %	Lines
near-sdk-macros/src/lib.rs	43.24%	21 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #1301      +/-   ##
==========================================
- Coverage   80.24%   80.06%   -0.18%     
==========================================
  Files         104      104              
  Lines       14819    14856      +37     
==========================================
+ Hits        11892    11895       +3     
- Misses       2927     2961      +34     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[akorchyn]

code changes: https://github.com/akorchyn/neardevhub-contract/compare/main...akorchyn:neardevhub-contract:test-near-macro-errors?expand=1

[dj8yfo]

code changes: https://github.com/akorchyn/neardevhub-contract/compare/main...akorchyn:neardevhub-contract:test-near-macro-errors?expand=1

TODO: + a devhub-community-factory there in, patching near-sdk in all dependent contracts, though it must've been defined once in workspace

[akorchyn]

Tested with discussions, community, community factory. All of them compiles.

UPD: the contracts are using near

[dj8yfo]

@akorchyn i cannot come up with any logical reason, how any of those could be affected, but now i feel calmer

[akorchyn]

That was a good call, I completely agree

[dj8yfo]

TODO: @akorchyn can you run cargo test --workspace with this patch there too? on 1.81 toolchain, otherwise it likely won't work.

there's one more aspect i want to check, which might be a breaking change; wanted to check it first

[dj8yfo]

nope, that was allright

[dj8yfo]

Judging from how this was layed outtg link, looks like it wouldn't conflict with this pr

[akorchyn]

It passes :)