Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

upgradability functionality #48

Merged
merged 20 commits into from
Sep 29, 2022
Merged

upgradability functionality #48

merged 20 commits into from
Sep 29, 2022

Conversation

kenobijon
Copy link
Contributor

Upgrade Function which will call "migrate" method in any contract

encody
encody suggested changes Sep 17, 2022
View reviewed changes
Copy link
Contributor

@encody encody left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing tests

@kenobijon kenobijon marked this pull request as draft September 18, 2022 15:07
@encody encody mentioned this pull request Sep 19, 2022
Closed
@kenobijon kenobijon requested a review from encody September 20, 2022 16:41
@kenobijon kenobijon marked this pull request as ready for review September 20, 2022 16:44
kenobijon
kenobijon commented Sep 20, 2022
View reviewed changes
Copy link
Contributor Author

@kenobijon kenobijon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added tests

@kenobijon kenobijon self-assigned this Sep 20, 2022
@kenobijon kenobijon added the enhancement New feature or request label Sep 20, 2022
encody
encody suggested changes Sep 21, 2022
View reviewed changes
Copy link
Contributor

@encody encody left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are we going to implement a rollback feature (e.g. calling migrate failed: rollback the contract to the previous code)?

@kenobijon kenobijon requested a review from encody September 22, 2022 09:37
encody
encody reviewed Sep 23, 2022
View reviewed changes
Copy link
Contributor

@encody encody left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just these two things. Otherwise looks good.

src/upgrade.rs
Comment on lines +16 to +19
pub trait UpgradeHook {
/// Executed before a upgrade call is conducted
fn on_upgrade();
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this function is ever called.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The idea was to keep it flexible

src/upgrade.rs Outdated

/// Upgrade Trait
pub trait Upgrade {
/// upgrade_all - Upgrades the code and the state of the contract
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this comment accurate?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated

@kenobijon kenobijon changed the title basic generic upgrade function upgradability functionality Sep 28, 2022
@encody encody merged commit aad160b into develop Sep 29, 2022
@encody encody deleted the upgradability branch September 29, 2022 05:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@encody encody encody approved these changes

Assignees

@encody encody

@kenobijon kenobijon

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kenobijon @encody