Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bypass Commit Modal Config #888

Merged
merged 4 commits into from
Jan 5, 2024
Merged

Bypass Commit Modal Config #888

merged 4 commits into from
Jan 5, 2024

Conversation

calebjacob
Copy link
Collaborator

@calebjacob calebjacob commented Dec 15, 2023

Closes: #787

Copy link

vercel bot commented Dec 15, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
near-discovery ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 4, 2024 11:27pm
near-discovery-testnet ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 4, 2024 11:27pm

@calebjacob calebjacob added the feature To highlight a PR's description in the 'New Features' changelog section label Dec 15, 2023
@calebjacob
Copy link
Collaborator Author

@charleslavon I did some quick testing on the preview builds and it looks like things are working as expected. The next step would be publishing a new VM version that we can link to whenever we feel that's ready.

@calebjacob
Copy link
Collaborator Author

Opened up a release PR to publish VM 2.5.4: NearSocial/VM#164

@calebjacob calebjacob marked this pull request as ready for review January 4, 2024 23:24
@calebjacob
Copy link
Collaborator Author

@charleslavon Got the official VM 2.5.4 version released and installed. The PR is ready for final testing and approval whenever we feel comfortable.

Copy link
Collaborator

@charleslavon charleslavon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👏🏾 I'm eager to get this live for more hands on feedback

I suspect we may want to consider what improvements we can make on the differences and interaction between this bypass and the Don't ask again for similar data toggle on the VM's confirmation modal
Screen Shot 2024-01-05 at 9 22 21 AM

Copy link
Contributor

@shelegdmitriy shelegdmitriy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@calebjacob calebjacob merged commit 254e1c5 into develop Jan 5, 2024
@calebjacob calebjacob deleted the feat/commit-modal-bypass branch January 5, 2024 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature To highlight a PR's description in the 'New Features' changelog section
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Gateway level whitelist for transaction signing
3 participants