Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: idOS design enhancement #607

Merged
merged 7 commits into from
Jan 16, 2024
Merged

Conversation

shelegdmitriy
Copy link
Contributor

@shelegdmitriy shelegdmitriy commented Jan 9, 2024

This PR introduces design enhancements.
A couple of things I made different but I can record a loom video describing all the changes I've made.

Closes: #885
Related to near/near-discovery#913

@shelegdmitriy shelegdmitriy added the enhancement To highlight a PR's description in the 'Enhancements' changelog section label Jan 9, 2024
@shelegdmitriy shelegdmitriy self-assigned this Jan 9, 2024
@shelegdmitriy shelegdmitriy marked this pull request as ready for review January 10, 2024 20:27
@charleslavon
Copy link
Collaborator

@shelegdmitriy a loom would be helpful.

What is the expected UX when landing on Settings.Verifications.Index for a user who has already verified humanness? I'm setting the UI show the page as if I have not yet setup idos, the only option it gives is to start the setup flow again.

Screen Shot 2024-01-11 at 10 19 36 AM

@charleslavon
Copy link
Collaborator

Ah, looks like this PR must be merged before this UX can be tested.

@shelegdmitriy
Copy link
Contributor Author

Ah, looks like this PR must be merged before this UX can be tested.

That's right

@charleslavon
Copy link
Collaborator

charleslavon commented Jan 12, 2024

@shelegdmitriy what's the expected UX here? I'm connected via mynearwallet, I'm already verified, but I get the UX as if I have never set this up. This is with bos-loader serving the components from this PR on beta.near.org which has your latest PR.

Screen Shot 2024-01-12 at 1 00 24 PM

@shelegdmitriy
Copy link
Contributor Author

@shelegdmitriy what's the expected UX here? I'm connected via mynearwallet, I'm already verified, but I get the UX as if I have never set this up. This is with bos-loader serving the components from this PR on beta.near.org which has your latest PR.

Screen Shot 2024-01-12 at 1 00 24 PM

Could you try to clear your local storage?

@charleslavon
Copy link
Collaborator

@shelegdmitriy I experience the same when connecting on an incognito window.

@shelegdmitriy
Copy link
Contributor Author

@shelegdmitriy I experience the same when connecting on an incognito window.

That's very interesting because it seems I found a couple of gaps in my code. Let me double check it and I'll ping you to test on your end. Sorry for that

@shelegdmitriy shelegdmitriy force-pushed the feat/idos-design-enhancement branch from 14dc4be to 89060b4 Compare January 16, 2024 15:42
@shelegdmitriy shelegdmitriy merged commit 49d3bbd into develop Jan 16, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement To highlight a PR's description in the 'Enhancements' changelog section
Projects
None yet
Development

Successfully merging this pull request may close these issues.

iDOS UX Enhancements
2 participants