Determine Participant Id automatically #400
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Terraform Feature Environment (dev-400)Terraform Initialization ⚙️
|
volovyks
changed the title
DavidM-D
reviewed
Jan 16, 2024
| use near_sdk::{AccountId, PublicKey}; | ||
| use std::collections::{BTreeMap, HashSet}; | ||
|
|
||
| pub mod hpke { |
There was a problem hiding this comment.
It's used to determine the public key type used for encrypting messages.
Crate: https://docs.rs/crate/hpke/latest
(it is not added by this PR)
DavidM-D
reviewed
Jan 16, 2024
| )] | ||
| pub struct CandidateInfo { | ||
| pub account_id: AccountId, | ||
| pub url: String, |
There was a problem hiding this comment.
If this is a URL, could it be a parsed one so a type like Url?
There was a problem hiding this comment.
I was avoiding it because such a check can be heavy for a contract. But it may be a good idea.
|
I might need a call to work out everything that's going on here. What issues does this PR close? |
itegulov
approved these changes
Jan 16, 2024
| let me = contract_state | ||
| .participants | ||
| .find_participant(ctx.my_account_id()) | ||
| .unwrap(); |
There was a problem hiding this comment.
This is going to be a brittle pattern going forward. me() does not exist in all contexts so we should strive to make this type safe and ensure we can only use it in the contexts where it exists. One potential solution to this is #416
Terraform Feature Environment Destroy (dev-400)Terraform Initialization ⚙️
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
me()function because the participant id is not available at that moment.