Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix documentation for Chain Signatures #2451

Merged
merged 12 commits into from
Jan 30, 2025
Merged

Fix documentation for Chain Signatures #2451

merged 12 commits into from
Jan 30, 2025

Conversation

graphite
Copy link
Contributor

@graphite graphite commented Jan 29, 2025 •
edited
Loading

fix: Fix broken links and inconsistencies in Chain Abstraction docs
fix: Broken links and anchors

@graphite graphite requested a review from bucanero as a code owner January 29, 2025 16:57
@render render bot temporarily deployed to anton/update-docs - near-docs PR #2451 January 29, 2025 16:57 Destroyed
@graphite graphite marked this pull request as draft January 29, 2025 18:03
@graphite
Copy link
Contributor Author

Converted to draft to address broken links and anchors while I am at it

@bucanero
Copy link
Collaborator

Converted to draft to address broken links and anchors while I am at it

let me know when it's ready and I'll review & merge! thank you!

@graphite graphite marked this pull request as ready for review January 30, 2025 15:20
@graphite
Copy link
Contributor Author

@bucanero I have fixed all the internal anchors and links except for:

  • /build/smart-contracts/anatomy/storage#initializing-the-state - this one exists and works, it is a CI false positive
  • /integrations/create-transactions#setting-up-connection-to-near-1 - same, CI false positive, likely because there are 2 identical section titles
  • /build/web3-apps/integrate-contracts#connecting-to-a-contract) - not sure where this should point, relevant section no longer exists

@bucanero bucanero merged commit ff3a2a5 into master Jan 30, 2025
1 of 3 checks passed
@bucanero bucanero deleted the anton/update-docs branch January 30, 2025 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bucanero bucanero bucanero approved these changes

Assignees
No one assigned
Labels
None yet
Projects
DevRel
Status: Shipped 🚀
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@graphite @bucanero