-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: running near_workspaces::compile_project
concurrently in tests
#266
Conversation
d144b24
to
d0fa87e
Compare
@@ -162,19 +162,37 @@ pub fn run(args: Opts) -> eyre::Result<CompilationArtifact> { | |||
color, | |||
)?; | |||
|
|||
wasm_artifact.path = crate::fs::copy(&wasm_artifact.path, &out_dir)?; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sometimes the final destination file is written with non-wasm-opt
-ed content,
which might be the reason of failures in concurrent context when many tests run
near_workspaces::compile_project
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
was able to easily reproduce this on this commit dj8yfo/near-sdk-rs@027ce75
receipts: [
ExecutionOutcome {
transaction_hash: 61H3aajosM8kDV3jbpuzFaAnMrTCb4DL871gVbbocNag,
block_hash: HVzmo5HTPZJySPhG5CXMPvde5kMTAGigWKgREbttsoBH,
logs: [],
receipt_ids: [
Dm63UmQr9mqrF6mDiRUxHTaWo8ESKbPHr1p9taEzSzaf,
],
gas_burnt: NearGas {
inner: 888148937360,
},
tokens_burnt: NearToken {
inner: 88814893736000000000,
},
executor_id: AccountId(
"dev-20241216183040-18506921751143",
),
status: Failure(ActionError(ActionError { index: Some(0), kind: FunctionCallError(CompilationError(PrepareError(Deserialization))) })),
},
],
status: Failure(ActionError(ActionError { index: Some(0), kind: FunctionCallError(CompilationError(PrepareError(Deserialization))) })),
}
thread 'test_storage_deposit_refunds_excessive_deposit' panicked at tests/workspaces.rs:86:5:
assertion failed: res.is_success()
failures:
simulate_transfer_call_when_called_contract_not_registered_with_ft
simulate_transfer_call_with_promise_and_refund
test_close_account_empty_balance
test_storage_deposit_refunds_excessive_deposit
test result: FAILED. 9 passed; 4 failed; 0 ignored; 0 measured; 0 filtered out; finished in 34.43s
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
adding near/near-sdk-rs@ffab607 with patch, pointing to current pr, on top of previous change (near/near-sdk-rs#1277) resolved flaky failures
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
corresponding run in near-sdk ci - https://github.com/near/near-sdk-rs/actions/runs/12359514121
d0fa87e
to
50516cf
Compare
50516cf
to
9df7503
Compare
compile_project
concurrently in testsnear_workspaces::compile_project
concurrently in tests
@race-of-sloths include |
@dj8yfo Thank you for your contribution! Your pull request is now a part of the Race of Sloths! Current status: executed
Your contribution is much appreciated with a final score of 8! @PolyProgrammist received 25 Sloth Points for reviewing and scoring this pull request. What is the Race of SlothsRace of Sloths is a friendly competition where you can participate in challenges and compete with other open-source contributors within your normal workflow For contributors:
For maintainers:
Feel free to check our website for additional details! Bot commands
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here - should be near organisation near/near-sdk-rs@ffab607
@race-of-sloths score 8 |
## 🤖 New release * `cargo-near`: 0.13.0 -> 0.13.1 (✓ API compatible changes) * `cargo-near-build`: 0.4.0 -> 0.4.1 (✓ API compatible changes) <details><summary><i><b>Changelog</b></i></summary><p> ## `cargo-near` <blockquote> ## [0.13.1](cargo-near-v0.13.0...cargo-near-v0.13.1) - 2024-12-18 ### Other - update `cargo near new` template `image` and `image_digest` ([#269](#269)) </blockquote> ## `cargo-near-build` <blockquote> ## [0.4.1](cargo-near-build-v0.4.0...cargo-near-build-v0.4.1) - 2024-12-18 ### Fixed - running `near_workspaces::compile_project` concurrently in tests (#266) </blockquote> </p></details> --- This PR was generated with [release-plz](https://github.com/release-plz/release-plz/).
Co-authored-by: dj8yf0μl <[email protected]>
## 🤖 New release * `near-workspaces`: 0.15.0 -> 0.16.0 (✓ API compatible changes) <details><summary><i><b>Changelog</b></i></summary><p> <blockquote> ## [0.16.0](near-workspaces-v0.15.0...near-workspaces-v0.16.0) - 2024-12-18 ### Fixed - include fix from near/cargo-near#266 (#395) ### Other - [**breaking**] updates near-* dependencies to 0.28 release (#392) </blockquote> </p></details> --- This PR was generated with [release-plz](https://github.com/release-plz/release-plz/).
this is suppossed to address this issue
https://github.com/near/near-workspaces-rs/blob/main/workspaces/src/cargo/mod.rs#L35-L41