Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-organize and update #128

Merged
merged 6 commits into from
Dec 12, 2024
Merged

Re-organize and update #128

merged 6 commits into from
Dec 12, 2024

Conversation

garikbesson
Copy link
Contributor

update dependencies, code structure, tests, README

@garikbesson garikbesson linked an issue Oct 28, 2024 that may be closed by this pull request
2 tasks
@gagdiez gagdiez self-requested a review December 2, 2024 16:39
@gagdiez
Copy link
Contributor

gagdiez commented Dec 2, 2024

@denbite, please take a look

@denbite
Copy link
Contributor

denbite commented Dec 10, 2024

I've written up more unit tests for better coverage, it's been increased from 69% to 96%
The remaining 4% belong to the ft_resolve_transfer function, which can't be tested properly with unit testing

Before
telegram-cloud-photo-size-2-5386478980707772720-y

After
telegram-cloud-photo-size-2-5386478980707772727-y

@garikbesson
Copy link
Contributor Author

I've written up more unit tests for better coverage, it's been increased from 69% to 96% The remaining 4% belong to the ft_resolve_transfer function, which can't be tested properly with unit testing

Before telegram-cloud-photo-size-2-5386478980707772720-y

After telegram-cloud-photo-size-2-5386478980707772727-y

What is that tool on your screens?

@denbite
Copy link
Contributor

denbite commented Dec 10, 2024

@denbite
Copy link
Contributor

denbite commented Dec 10, 2024

  • restructured integration tests to make them as deterministic as possible
  • improved readability of tests folder
  • compiled DeFi contract so we don't have to do it for each test case
  • introduced lazy compilation of Fungible Token inside tests to prevent the same contract from being built many times

@gagdiez gagdiez merged commit cd3f5c5 into master Dec 12, 2024
2 checks passed
@gagdiez gagdiez deleted the reorganize-and-update branch December 12, 2024 17:01
@garikbesson garikbesson linked an issue Dec 16, 2024 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update and re-organize FT example Not enough non-option arguments: got 0, need at least 2
3 participants