Add spotbugs and clang-tidy suppressions

test/extensions/language/choice_types/ClangTidySuppressions.txt

@@ -1,3 +1,8 @@
+bugprone-exception-escape:gen/choice_types/multiple_param_choice/TestChoice.cpp
+bugprone-exception-escape:gen/choice_types/multiple_param_choice/TestChoice.h
+
+bugprone-forwarding-reference-overload:gen/choice_types/multiple_param_choice/Data13.h
+
 bugprone-unhandled-self-assignment:gen/choice_types/function_returning_literal_selector_choice/TestChoice.cpp
 bugprone-unhandled-self-assignment:gen/choice_types/function_selector_choice/TestChoice.cpp
 
@@ -10,16 +15,18 @@ cppcoreguidelines-pro-type-member-init:gen/choice_types/choice_compatibility_che
 cppcoreguidelines-pro-type-member-init:gen/choice_types/choice_with_array/TestChoice.cpp
 cppcoreguidelines-pro-type-member-init:gen/choice_types/constant_in_choice_case/ConstantInChoiceCase.cpp
 cppcoreguidelines-pro-type-member-init:gen/choice_types/default_empty_choice/DefaultEmptyChoice.cpp
-cppcoreguidelines-pro-type-member-init:gen/choice_types/empty_choice/EmptyChoice.cpp
 cppcoreguidelines-pro-type-member-init:gen/choice_types/empty_choice_with_case/EmptyChoiceWithCase.cpp
 cppcoreguidelines-pro-type-member-init:gen/choice_types/empty_choice_with_default/EmptyChoiceWithDefault.cpp
+cppcoreguidelines-pro-type-member-init:gen/choice_types/empty_choice/EmptyChoice.cpp
 cppcoreguidelines-pro-type-member-init:gen/choice_types/enum_param_choice/EnumParamChoice.cpp
 cppcoreguidelines-pro-type-member-init:gen/choice_types/enum_with_removed_item_param_choice/EnumWithRemovedItemParamChoice.cpp
 cppcoreguidelines-pro-type-member-init:gen/choice_types/expression_selector_choice/ExpressionSelectorChoice.cpp
 cppcoreguidelines-pro-type-member-init:gen/choice_types/full_enum_param_choice/FullEnumParamChoice.cpp
 cppcoreguidelines-pro-type-member-init:gen/choice_types/function_returning_literal_selector_choice/Selector.cpp
 cppcoreguidelines-pro-type-member-init:gen/choice_types/function_returning_literal_selector_choice/TestChoice.cpp
 cppcoreguidelines-pro-type-member-init:gen/choice_types/function_selector_choice/TestChoice.cpp
+cppcoreguidelines-pro-type-member-init:gen/choice_types/multiple_param_choice/Data13.cpp
+cppcoreguidelines-pro-type-member-init:gen/choice_types/multiple_param_choice/TestChoice.cpp
 cppcoreguidelines-pro-type-member-init:gen/choice_types/uint16_param_choice/UInt16ParamChoice.cpp
 cppcoreguidelines-pro-type-member-init:gen/choice_types/uint32_param_choice/UInt32ParamChoice.cpp
 cppcoreguidelines-pro-type-member-init:gen/choice_types/uint64_param_choice/UInt64ParamChoice.cpp
@@ -38,8 +45,8 @@ readability-make-member-function-const:gen/choice_types/bitmask_param_choice/Bit
 readability-make-member-function-const:gen/choice_types/bool_param_choice/BoolParamChoice.cpp
 readability-make-member-function-const:gen/choice_types/choice_compatibility_check/ChoiceVersion1.cpp
 readability-make-member-function-const:gen/choice_types/choice_compatibility_check/ChoiceVersion2.cpp
-readability-make-member-function-const:gen/choice_types/choice_compatibility_check/CoordXYZ.cpp
 readability-make-member-function-const:gen/choice_types/choice_compatibility_check/CoordXY.cpp
+readability-make-member-function-const:gen/choice_types/choice_compatibility_check/CoordXYZ.cpp
 readability-make-member-function-const:gen/choice_types/choice_compatibility_check/HolderVersion1.cpp
 readability-make-member-function-const:gen/choice_types/choice_compatibility_check/HolderVersion2.cpp
 readability-make-member-function-const:gen/choice_types/choice_with_array/Data8.cpp
@@ -51,6 +58,7 @@ readability-make-member-function-const:gen/choice_types/expression_selector_choi
 readability-make-member-function-const:gen/choice_types/full_bitmask_param_choice/FullBitmaskParamChoice.cpp
 readability-make-member-function-const:gen/choice_types/full_enum_param_choice/FullEnumParamChoice.cpp
 readability-make-member-function-const:gen/choice_types/function_selector_choice/Selector.cpp
+readability-make-member-function-const:gen/choice_types/multiple_param_choice/Data13.cpp
 readability-make-member-function-const:gen/choice_types/uint16_param_choice/UInt16ParamChoice.cpp
 readability-make-member-function-const:gen/choice_types/uint32_param_choice/UInt32ParamChoice.cpp
 readability-make-member-function-const:gen/choice_types/uint64_param_choice/UInt64ParamChoice.cpp

test/extensions/language/choice_types/spotbugs_filter.xml

@@ -2,7 +2,10 @@
     <Match>
         <!-- Method uses the same code for two switch clauses. -->
         <Bug code="DB"/>
-        <Class name="choice_types.choice_with_array.TestChoice"/>
+        <Or>
+            <Class name="choice_types.choice_with_array.TestChoice"/>
+            <Class name="choice_types.multiple_param_choice.TestChoice"/>
+        </Or>
         <Or>
             <Method name="hashCode"/>
             <Method name="bitSizeOf"/>

test/extensions/language/optional_members/ClangTidySuppressions.txt

@@ -5,6 +5,10 @@ cert-err58-cpp:cpp/OptionalArrayRecursionTest.cpp
 cppcoreguidelines-pro-type-member-init:gen/optional_members/optional_expression/BlackColor.cpp
 cppcoreguidelines-pro-type-member-init:gen/optional_members/optional_recursion/Block.cpp
 
+google-explicit-constructor:gen/optional_members/optional_complex_expression/Permission.h
+
+hicpp-signed-bitwise:gen/optional_members/optional_complex_expression/Permission.h
+
 hicpp-multiway-paths-covered:gen/optional_members/optional_expression_with_removed_enum_item/Numbers.cpp
 
 misc-no-recursion # reports also tested_release and some system headers
@@ -15,7 +19,8 @@ performance-move-const-arg:gen/optional_members/optional_recursion/Block.cpp
 readability-make-member-function-const:gen/optional_members/auto_optional/Container.cpp
 readability-make-member-function-const:gen/optional_members/optional_array/Data8.cpp
 readability-make-member-function-const:gen/optional_members/optional_array/TestStruct.cpp
+readability-make-member-function-const:gen/optional_members/optional_complex_expression/Container.cpp
+readability-make-member-function-const:gen/optional_members/optional_expression_with_removed_enum_item/Compound.cpp
 readability-make-member-function-const:gen/optional_members/optional_expression/BlackColor.cpp
 readability-make-member-function-const:gen/optional_members/optional_expression/Container.cpp
-readability-make-member-function-const:gen/optional_members/optional_expression_with_removed_enum_item/Compound.cpp
 readability-make-member-function-const:gen/optional_members/optional_recursion/Block.cpp

test/extensions/language/parameterized_types/ClangTidySuppressions.txt

@@ -1,8 +1,9 @@
 bugprone-exception-escape:gen/parameterized_types/grand_child_param/ItemChoice.cpp
 bugprone-exception-escape:gen/parameterized_types/grand_child_param/ItemChoice.h
 
-bugprone-forwarding-reference-overload:gen/parameterized_types/array_element_param/Block.h
 bugprone-forwarding-reference-overload:gen/parameterized_types/array_element_param_with_optional/ExtraValue.h
+bugprone-forwarding-reference-overload:gen/parameterized_types/array_element_param/Block.h
+bugprone-forwarding-reference-overload:gen/parameterized_types/multiple_params/Data13.h
 bugprone-forwarding-reference-overload:gen/parameterized_types/nested_parameterized_field/TopLevel.h
 bugprone-forwarding-reference-overload:gen/parameterized_types/param_with_optional/ExtraValue.h
 bugprone-forwarding-reference-overload:gen/parameterized_types/parameterized_inner_classes_clashing/ElementChildrenInitializer_array.h
@@ -25,23 +26,25 @@ cert-err58-cpp:cpp/NestedParameterizedFieldTest.cpp
 cert-err58-cpp:cpp/PackedArrayElementParamTest.cpp
 cert-err58-cpp:cpp/ParamWithOptionalTest.cpp
 
-cppcoreguidelines-pro-type-member-init:gen/parameterized_types/array_element_param/Block.cpp
 cppcoreguidelines-pro-type-member-init:gen/parameterized_types/array_element_param_with_optional/ExtraValue.cpp
 cppcoreguidelines-pro-type-member-init:gen/parameterized_types/array_element_param_with_optional/Value.cpp
+cppcoreguidelines-pro-type-member-init:gen/parameterized_types/array_element_param/Block.cpp
 cppcoreguidelines-pro-type-member-init:gen/parameterized_types/bytes_param/Parameterized.cpp
 cppcoreguidelines-pro-type-member-init:gen/parameterized_types/dynamic_bitfield_param/DynamicBitfieldParam.cpp
 cppcoreguidelines-pro-type-member-init:gen/parameterized_types/extern_param/Parameterized.cpp
 cppcoreguidelines-pro-type-member-init:gen/parameterized_types/fixed_and_variable_param/ArrayHolder.cpp
-cppcoreguidelines-pro-type-member-init:gen/parameterized_types/grand_child_param/ItemChoice.cpp
 cppcoreguidelines-pro-type-member-init:gen/parameterized_types/grand_child_param/Item.cpp
+cppcoreguidelines-pro-type-member-init:gen/parameterized_types/grand_child_param/ItemChoice.cpp
+cppcoreguidelines-pro-type-member-init:gen/parameterized_types/multiple_params/Data13.cpp
+cppcoreguidelines-pro-type-member-init:gen/parameterized_types/multiple_params/TestStructure.cpp
 cppcoreguidelines-pro-type-member-init:gen/parameterized_types/nested_parameterized_field/Param.cpp
 cppcoreguidelines-pro-type-member-init:gen/parameterized_types/packed_array_element_param/Block.cpp
 cppcoreguidelines-pro-type-member-init:gen/parameterized_types/param_with_optional/ExtraValue.cpp
 cppcoreguidelines-pro-type-member-init:gen/parameterized_types/param_with_optional/Value.cpp
 cppcoreguidelines-pro-type-member-init:gen/parameterized_types/parameterized_inner_classes_clashing/Compound.cpp
 cppcoreguidelines-pro-type-member-init:gen/parameterized_types/parameterized_nested_in_array/Parameterized.cpp
-cppcoreguidelines-pro-type-member-init:gen/parameterized_types/parameterized_param/ParameterizedParam.cpp
 cppcoreguidelines-pro-type-member-init:gen/parameterized_types/parameterized_param/Param.cpp
+cppcoreguidelines-pro-type-member-init:gen/parameterized_types/parameterized_param/ParameterizedParam.cpp
 cppcoreguidelines-pro-type-member-init:gen/parameterized_types/simple_param/Item.cpp
 cppcoreguidelines-pro-type-member-init:gen/parameterized_types/subtyped_bitfield_param/SubtypedBitfieldParam.cpp
 
@@ -51,13 +54,14 @@ hicpp-signed-bitwise:gen/parameterized_types/fixed_and_variable_param/Access.h
 
 performance-move-const-arg:gen/parameterized_types/array_element_param/Database.cpp
 performance-move-const-arg:gen/parameterized_types/bytes_param/Parameterized.cpp
-performance-move-const-arg:gen/parameterized_types/dynamic_bitfield_param/DynamicBitfieldParamHolder.cpp
 performance-move-const-arg:gen/parameterized_types/dynamic_bitfield_param/DynamicBitfieldParam.cpp
+performance-move-const-arg:gen/parameterized_types/dynamic_bitfield_param/DynamicBitfieldParamHolder.cpp
 performance-move-const-arg:gen/parameterized_types/extern_param/Parameterized.cpp
 performance-move-const-arg:gen/parameterized_types/fixed_and_variable_param/ArrayHolder.cpp
 performance-move-const-arg:gen/parameterized_types/fixed_and_variable_param/FixedAndVariableParam.cpp
-performance-move-const-arg:gen/parameterized_types/grand_child_param/ItemChoiceHolder.cpp
 performance-move-const-arg:gen/parameterized_types/grand_child_param/Item.cpp
+performance-move-const-arg:gen/parameterized_types/grand_child_param/ItemChoiceHolder.cpp
+performance-move-const-arg:gen/parameterized_types/multiple_params/TestStructure.cpp
 performance-move-const-arg:gen/parameterized_types/nested_parameterized_field/Param.cpp
 performance-move-const-arg:gen/parameterized_types/nested_parameterized_field/ParamHolder.cpp
 performance-move-const-arg:gen/parameterized_types/packed_array_element_param/Block.cpp
@@ -67,24 +71,26 @@ performance-move-const-arg:gen/parameterized_types/parameterized_inner_classes_c
 performance-move-const-arg:gen/parameterized_types/parameterized_inner_classes_clashing/ElementInitializer_array.cpp
 performance-move-const-arg:gen/parameterized_types/parameterized_inner_classes_clashing/Parent.cpp
 performance-move-const-arg:gen/parameterized_types/parameterized_nested_in_array/Parameterized.cpp
-performance-move-const-arg:gen/parameterized_types/parameterized_param/ParameterizedParamHolder.cpp
-performance-move-const-arg:gen/parameterized_types/parameterized_param/ParameterizedParam.cpp
 performance-move-const-arg:gen/parameterized_types/parameterized_param/Param.cpp
+performance-move-const-arg:gen/parameterized_types/parameterized_param/ParameterizedParam.cpp
+performance-move-const-arg:gen/parameterized_types/parameterized_param/ParameterizedParamHolder.cpp
 performance-move-const-arg:gen/parameterized_types/simple_param/Item.cpp
 performance-move-const-arg:gen/parameterized_types/subtyped_bitfield_param/SubtypedBitfieldParam.cpp
 
-readability-make-member-function-const:gen/parameterized_types/array_element_param/BlockHeader.cpp
 readability-make-member-function-const:gen/parameterized_types/array_element_param_with_optional/ExtraValue.cpp
 readability-make-member-function-const:gen/parameterized_types/array_element_param_with_optional/Param.cpp
+readability-make-member-function-const:gen/parameterized_types/array_element_param/BlockHeader.cpp
 readability-make-member-function-const:gen/parameterized_types/bytes_param/Parameterized.cpp
-readability-make-member-function-const:gen/parameterized_types/dynamic_bitfield_param/DynamicBitfieldParamHolder.cpp
 readability-make-member-function-const:gen/parameterized_types/dynamic_bitfield_param/DynamicBitfieldParam.cpp
+readability-make-member-function-const:gen/parameterized_types/dynamic_bitfield_param/DynamicBitfieldParamHolder.cpp
 readability-make-member-function-const:gen/parameterized_types/extern_param/Parameterized.cpp
 readability-make-member-function-const:gen/parameterized_types/fixed_and_variable_param/ArrayHolder.cpp
 readability-make-member-function-const:gen/parameterized_types/fixed_and_variable_param/LimitHolder.cpp
-readability-make-member-function-const:gen/parameterized_types/grand_child_param/ItemChoiceHolder.cpp
-readability-make-member-function-const:gen/parameterized_types/grand_child_param/ItemChoice.cpp
 readability-make-member-function-const:gen/parameterized_types/grand_child_param/Item.cpp
+readability-make-member-function-const:gen/parameterized_types/grand_child_param/ItemChoice.cpp
+readability-make-member-function-const:gen/parameterized_types/grand_child_param/ItemChoiceHolder.cpp
+readability-make-member-function-const:gen/parameterized_types/multiple_params/Data13.cpp
+readability-make-member-function-const:gen/parameterized_types/multiple_params/TestStructure.cpp
 readability-make-member-function-const:gen/parameterized_types/nested_parameterized_field/Param.cpp
 readability-make-member-function-const:gen/parameterized_types/nested_parameterized_field/ParamHolder.cpp
 readability-make-member-function-const:gen/parameterized_types/packed_array_element_param/BlockHeader.cpp
@@ -93,8 +99,8 @@ readability-make-member-function-const:gen/parameterized_types/param_with_option
 readability-make-member-function-const:gen/parameterized_types/parameterized_inner_classes_clashing/Compound.cpp
 readability-make-member-function-const:gen/parameterized_types/parameterized_inner_classes_clashing/Parent.cpp
 readability-make-member-function-const:gen/parameterized_types/parameterized_nested_in_array/Parameterized.cpp
-readability-make-member-function-const:gen/parameterized_types/parameterized_param/ParameterizedParamHolder.cpp
 readability-make-member-function-const:gen/parameterized_types/parameterized_param/Param.cpp
+readability-make-member-function-const:gen/parameterized_types/parameterized_param/ParameterizedParamHolder.cpp
 readability-make-member-function-const:gen/parameterized_types/simple_param/Item.cpp
 readability-make-member-function-const:gen/parameterized_types/subtyped_bitfield_param/SubtypedBitfieldParam.cpp
 

test/extensions/language/union_types/ClangTidySuppressions.txt

@@ -1,6 +1,9 @@
+bugprone-exception-escape:gen/union_types/union_with_multiple_parameters/TestUnion.cpp
+bugprone-exception-escape:gen/union_types/union_with_multiple_parameters/TestUnion.h
 bugprone-exception-escape:gen/union_types/union_with_parameterized_field/TestUnion.cpp
 bugprone-exception-escape:gen/union_types/union_with_parameterized_field/TestUnion.h
 
+bugprone-forwarding-reference-overload:gen/union_types/union_with_multiple_parameters/Data13.h
 bugprone-forwarding-reference-overload:gen/union_types/union_with_parameterized_field/ArrayHolder.h
 
 cert-err58-cpp:cpp/SimpleUnionTest.cpp
@@ -10,17 +13,22 @@ cert-err58-cpp:cpp/UnionWithArrayTest.cpp
 cppcoreguidelines-pro-bounds-constant-array-index:cpp/UnionWithArrayTest.cpp
 
 cppcoreguidelines-pro-type-member-init:gen/union_types/empty_union_with_parameter/EmptyUnionWithParameter.cpp
-cppcoreguidelines-pro-type-member-init:gen/union_types/union_with_parameterized_field/ArrayHolder.cpp
+cppcoreguidelines-pro-type-member-init:gen/union_types/union_with_multiple_parameters/Data13.cp
+cppcoreguidelines-pro-type-member-init:gen/union_types/union_with_multiple_parameters/Data13.cpp
+cppcoreguidelines-pro-type-member-init:gen/union_types/union_with_multiple_parameters/TestUnion.cpp
 cppcoreguidelines-pro-type-member-init:gen/union_types/union_with_parameter/TestUnion.cpp
+cppcoreguidelines-pro-type-member-init:gen/union_types/union_with_parameterized_field/ArrayHolder.cpp
 
 performance-move-const-arg:gen/union_types/union_compatibility_check/UnionVersion1.cpp
 performance-move-const-arg:gen/union_types/union_compatibility_check/UnionVersion2.cpp
 performance-move-const-arg:gen/union_types/union_with_parameter/TestUnion.cpp
 performance-move-const-arg:cpp/EmptyUnionTest.cpp
 
-readability-make-member-function-const:gen/union_types/union_compatibility_check/CoordXYZ.cpp
 readability-make-member-function-const:gen/union_types/union_compatibility_check/CoordXY.cpp
+readability-make-member-function-const:gen/union_types/union_compatibility_check/CoordXYZ.cpp
 readability-make-member-function-const:gen/union_types/union_with_array/Data8.cpp
+readability-make-member-function-const:gen/union_types/union_with_multiple_parameters/Data13.cpp
 readability-make-member-function-const:gen/union_types/union_with_parameterized_field/ArrayHolder.cpp
 
 readability-simplify-boolean-expr:gen/union_types/empty_union/EmptyUnion.cpp
+

test/extensions/language/union_types/spotbugs_filter.xml

@@ -5,6 +5,7 @@
         <Or>
             <Class name="union_types.simple_union.SimpleUnion"/>
             <Class name="union_types.union_with_array.TestUnion"/>
+            <Class name="union_types.union_with_multiple_parameters.TestUnion"/>
         </Or>
         <Or>
             <Method name="hashCode"/>