Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Datasource Config UI #157

Merged
merged 11 commits into from
Sep 18, 2024
Merged

Datasource Config UI #157

merged 11 commits into from
Sep 18, 2024

Conversation

Waguramu
Copy link
Contributor

@Waguramu Waguramu commented Sep 9, 2024 •
edited
Loading

Goal: allow users to alter Mapget DataSources configuration using Erdblick UI.

Scope:

  • DatasourcesComponent
  • DatasourcesService
  • EditorComponent
  • EditorService

Deliverables:

  • A component that allows to open an editor with pre-filled DataSources configuration which can be modified and applied.
  • A service that allows to communicate with Mapget endpoints.

How to test:

  1. Build as usual.
  2. Serve with mapget/config-endpoint branch.

Notes:

@Waguramu Waguramu self-assigned this Sep 9, 2024
@Waguramu Waguramu changed the base branch from main to zoom-feature September 9, 2024 08:16
@Waguramu Waguramu marked this pull request as ready for review September 10, 2024 13:32
Waguramu and others added 11 commits September 17, 2024 09:40
@Waguramu @josephbirkner
* Add bounding radius vector point
c5bd400 
* Add KeyboardService
* Add zoom to feature shortcut
@Waguramu @josephbirkner
* Add search history
7bc63af 
* Update search input
* Add resizable container
* Update actions and history entries to be selectable with keyboard
@Waguramu @josephbirkner
* Add coreLib getGeometryType
56f4b7a 
* Add search result ID
* Refactoring
@Waguramu @josephbirkner
* Add keyboard movement shortcuts
3f76664 
* Add dialog escape functions
* Add tabbing across UI elements
@Waguramu @josephbirkner
Add datasource config UI
fab58d4
@Waguramu @josephbirkner
Refactoring
541584e
@Waguramu @josephbirkner
Fix reported error messages
88c3210
@josephbirkner
Fix eslint complaints.
830e7c2
@josephbirkner
Do not request selection tiles for unavailable map layers.
586bf05
@josephbirkner
Use style options for highlights as well.
aa4692d
@josephbirkner
Attach mapId to feature inspection nodes.
4c209ec
josephbirkner
josephbirkner approved these changes Sep 18, 2024
View reviewed changes
Copy link
Collaborator

@josephbirkner josephbirkner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved!

@josephbirkner josephbirkner merged commit 00fa34e into zoom-feature Sep 18, 2024
4 checks passed
@josephbirkner josephbirkner deleted the datasource-config branch September 18, 2024 20:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@josephbirkner josephbirkner josephbirkner approved these changes

@MisterGC MisterGC Awaiting requested review from MisterGC

Assignees

@Waguramu Waguramu

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Waguramu @josephbirkner