Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Keyboard Controls #156

Merged
merged 7 commits into from
Sep 9, 2024
Merged

Keyboard Controls #156

merged 7 commits into from
Sep 9, 2024

Conversation

Waguramu
Copy link
Contributor

@Waguramu Waguramu commented Sep 3, 2024

Goal: add shortcuts and Tab/Enter/Esc functionality to improve navigation.

Scope:
#87

Deliverables:

  • Updated KeyboardService
  • Add tab indices and Enter directive

How to test:

  • Build as usual and serve with mapget.

Notes:

  • Inputs are affected by the captured shortcuts.

@Waguramu Waguramu self-assigned this Sep 3, 2024
@Waguramu
Copy link
Contributor Author

Waguramu commented Sep 3, 2024 •
edited
Loading

TODOs:

  • Make sure that Esc works on dialogs correctly.
  • Make sure that inputs are cleared on Esc correctly.
  • Make sure that single letter shortcuts won't affect inputs anymore.
  • Add functionality for R (reset camera tilt/orientation) and M (open Map panel)

@Waguramu Waguramu changed the base branch from main to zoom-feature September 9, 2024 08:17
@Waguramu
* Add bounding radius vector point
17d3755 
* Add KeyboardService
* Add zoom to feature shortcut
@Waguramu
* Add search history
0004876 
* Update search input
* Add resizable container
* Update actions and history entries to be selectable with keyboard
@Waguramu
Update search menu appearance with more icons and without tabView
dcaff06
@Waguramu
* Add coreLib getGeometryType
865b940 
* Add search result ID
* Refactoring
@Waguramu
* Add keyboard movement shortcuts
341742a 
* Add dialog escape functions
* Add tabbing across UI elements
@Waguramu
* Add M and R shortcuts
70de75e 
* Add multiple shortcuts per binding
* Refactor KeyboardService listener
@Waguramu Waguramu marked this pull request as ready for review September 9, 2024 14:18
@Waguramu Waguramu merged commit 710fbeb into zoom-feature Sep 9, 2024
1 check passed
@Waguramu Waguramu deleted the keyboard-controls branch September 9, 2024 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MisterGC MisterGC Awaiting requested review from MisterGC

@josephbirkner josephbirkner Awaiting requested review from josephbirkner

Assignees

@Waguramu Waguramu

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@Waguramu