Merged Point Features + Hover Highlight Styles #150
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
josephbirkner
force-pushed
the
merged-features
branch
2 times, most recently
from
582af50 to
f819856
Compare
josephbirkner
force-pushed
the
merged-features
branch
from
95a28ec to
9410bf8
Compare
josephbirkner
changed the title
josephbirkner
force-pushed
the
merged-features
branch
from
1878168 to
80cb73c
Compare
Waguramu
force-pushed
the
merged-features
branch
from
e03ed9f to
0ff9530
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #80
Fixes #119
This PR contains two major new styling system improvements: Hover styles, and merged point styling. Merged point styling is an evolution of our previous
modestyle field. Instead ofhighlightornormal,modecan now be set tohoverorselection. The hover style is now also applied on the target feature, when a feature ID in the attribute panel is being hovered.By setting
point-merge-grid-cell, a tolerance may be defined which allows merging the visual representations of point features which share the same 3D spatial cell, map, layer, and style rule. This has two advantages:$mergeCount: In some map formats, it may be desirable to apply a style based on the number of merged points.This may be done to display a warning, or to check a matching requirement.
To this end, the
$mergeCountvariable is injected into each simfil evaluation context of a merged-point style rule.Check out the default style for an example.
You can simply test both features, by running the mapviewer with the default style and Island 6.