Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the condition to check if a model's tokenizer has a padding token is wrong and always evaluates to
True
, meaning all models get patched whether they require it or not.Normally,
hasattr()
should be used on an object to check whether it has a given attribute or not, while here it was used on the attribute directly (hasattr(my_object, "my_attribute")
vshasattr(my_object.my_attribute, "my_attribute")
). But it shouldn't be used at all here because even models without a padding token have apad_token
attribute, it's just set toNone
which is what's tested for in this PR.Maybe related to #177 but couldn't reproduce the error there.