Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix:Multilingual preflabels #221

Merged
merged 3 commits into from
Oct 21, 2024
Merged

fix:Multilingual preflabels #221

merged 3 commits into from
Oct 21, 2024

Conversation

alexskr
Copy link
Member

@alexskr alexskr commented Oct 21, 2024

Copy link

codecov bot commented Oct 21, 2024

Codecov Report

Attention: Patch coverage is 90.90909% with 1 line in your changes missing coverage. Please review.

Project coverage is 81.25%. Comparing base (fbd7548) to head (e7d2124).
Report is 5 commits behind head on develop.

Files with missing lines Patch % Lines
...ion_process/operations/submission_rdf_generator.rb 90.90% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #221      +/-   ##
===========================================
+ Coverage    81.08%   81.25%   +0.17%     
===========================================
  Files           74       74              
  Lines         5244     5250       +6     
===========================================
+ Hits          4252     4266      +14     
+ Misses         992      984       -8     
Flag Coverage Δ
unittests 81.25% <90.90%> (+0.17%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@alexskr alexskr marked this pull request as ready for review October 21, 2024 23:15
@alexskr alexskr merged commit a7a7464 into develop Oct 21, 2024
6 checks passed
@jvendetti
Copy link
Member

@alexskr
@mdorf

The initial comment in this pull request indicates that it addresses ncbo/bioportal_web_ui#335, but the issue is still present. See ncbo/bioportal_web_ui#335 (comment) for an example.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants