Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Multilingual support #150

Merged
merged 11 commits into from
Apr 24, 2024

Conversation

syphax-bouazzouni
Copy link

@syphax-bouazzouni syphax-bouazzouni commented Apr 17, 2024

Require

Context

The equivalent of ontoportal-lirmm#44, and implement better support of multilingual, giving the possibility to filter the fetched data from the triples store, to return only the ones matching one language (e.g fr for French), multiple languages (e.g en, fr for English and french), or all.

See the created tests for examples

Changes

  • Add multilingual support cases tests (e72d643)
  • Add request store dependency to save globally the language per request (7215f49)
  • Add languages settings dsl to define the main language of the portal (d6e8c33)
  • Create a module in SPARQL mixins to handle language filter logic (163a3de)
  • Make map_attributes support multilingual (f34f2b0)

@syphax-bouazzouni syphax-bouazzouni changed the title Feature: Multilingual & MultiBackend stores support Feature: Multilingual support Apr 17, 2024
@syphax-bouazzouni syphax-bouazzouni force-pushed the pr/sync-agroportal-bioportal branch from 7bf4c99 to 27fbe7d Compare April 17, 2024 18:44
@codecov-commenter
Copy link

codecov-commenter commented Apr 17, 2024

Codecov Report

Attention: Patch coverage is 89.92537% with 27 lines in your changes are missing coverage. Please review.

Project coverage is 87.05%. Comparing base (87e991b) to head (fb04e78).
Report is 29 commits behind head on develop.

Files Patch % Lines
lib/goo/sparql/mixins/solution_lang_filter.rb 91.75% 8 Missing ⚠️
lib/goo/base/resource.rb 75.00% 6 Missing ⚠️
lib/goo.rb 61.53% 5 Missing ⚠️
lib/goo/sparql/query_builder.rb 92.18% 5 Missing ⚠️
lib/goo/sparql/solutions_mapper.rb 94.11% 3 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #150      +/-   ##
===========================================
+ Coverage    84.53%   87.05%   +2.51%     
===========================================
  Files           35       36       +1     
  Lines         2516     2626     +110     
===========================================
+ Hits          2127     2286     +159     
+ Misses         389      340      -49     
Flag Coverage Δ
unittests 87.05% <89.92%> (+2.51%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants