React 19 #1618
Merged
React 19 #1618
+71
−116
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andersrognstad
commented
Jan 23, 2025
| @@ -17,7 +17,7 @@ export const ExpandableBlockquote = ({ | |||
| children, | |||
| }: ExpandableBlockquoteProps) => { | |||
| const [viewAll, setViewAll] = React.useState<boolean>(false); | |||
| const ref = React.useRef() as RefObject<any>; | |||
| const ref = React.useRef(null) as RefObject<any>; | |||
There was a problem hiding this comment.
andersrognstad
commented
Jan 23, 2025
| {...props} | ||
| /> | ||
| ); | ||
|
|
||
| export default React.forwardRef(DialogmoteKlokkeslett); |
There was a problem hiding this comment.
Denne er deprecated (https://imrankhani.medium.com/react-19-deprecated-forwardref-a-guide-to-passing-ref-as-a-standard-prop-7c0f13e6a229).
Det er react-hook-form som sender inn ref til disse komponentene der hvor de brukes og ref er nå en standard prop.
andersrognstad
commented
Jan 23, 2025
| @@ -66,7 +66,7 @@ export const VelgBehandler = ({ | |||
| </Radio> | |||
| ))} | |||
| <Radio | |||
| value={undefined} | |||
| value="" | |||
There was a problem hiding this comment.
Fikk en snodig bug her som en test fanget opp: undefined ble til verdien "on" når man valgte radioknappen, som gjorde at validering ikke feilet (fordi "on" ikke er falsy). Vi ønsker valideringsfeil når man har valgt radioknappen for "Søk etter behandler" uten å ha søkt opp behandler.
mariusfoss
approved these changes
Jan 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.