POFIM-169 Arbeidsgiverinitiert inntektsmelding #347
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lagt inn mulighet for å sende inn en SendInntektsmeldingRequestDto uten forespørselId og nye metoder for å støtte arbeidsgiveriniert im.
|
Før denne merges så må vi finne ut om vi skal opprette oppgave for disse eller ikke |
pekern
reviewed
Jan 24, 2025
There was a problem hiding this comment.
Ser bra ut for meg. Noen ting jeg har tenkt på:
- Burde vi hatt en egen ForespørselStatus som vi lagrer disse med, for å enkelt kunne skille de fra andre "naturlige" forespørsler?
- Så vidt jeg kan se bør det går bra å fjerne oppgaveId på forespørselen så lenge vi gjør nullsjekker der den brukes i dag. Da slipper vi også opprette oppgaver
…nntektsmeldinger, og lagt til ny lukke status for å kunne indentifisere inntektsmeldinger av denne typen.
…Id på forespørsel til optional
johannbm
approved these changes
Jan 24, 2025
pekern
approved these changes
Jan 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Lagt inn mulighet for å sende inn en SendInntektsmeldingRequestDto uten forespørselId og nye metoder for å støtte arbeidsgiveriniert im.