-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Legg til endepunkt for å slå opp arbeidstaker #239
Merged
selbekk
merged 26 commits into
master
from
legg-til-endepunkt-for-oppslag-av-arbeidstaker
Jan 15, 2025
Merged
Legg til endepunkt for å slå opp arbeidstaker #239
selbekk
merged 26 commits into
master
from
legg-til-endepunkt-for-oppslag-av-arbeidstaker
Jan 15, 2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
selbekk
commented
Nov 12, 2024
...tektsmelding/refusjonomsorgsdagerarbeidsgiver/rest/RefusjonOmsorgsdagerArbeidsgiverRest.java
Show resolved
Hide resolved
selbekk
commented
Nov 12, 2024
src/main/java/no/nav/familie/inntektsmelding/koder/Behandlingtema.java
Outdated
Show resolved
Hide resolved
src/main/java/no/nav/familie/inntektsmelding/koder/Ytelsetype.java
Outdated
Show resolved
Hide resolved
mrsladek
reviewed
Nov 12, 2024
...tektsmelding/refusjonomsorgsdagerarbeidsgiver/rest/RefusjonOmsorgsdagerArbeidsgiverRest.java
Show resolved
Hide resolved
mrsladek
reviewed
Nov 12, 2024
...in/java/no/nav/familie/inntektsmelding/integrasjoner/arbeidsgivernotifikasjon/Merkelapp.java
Outdated
Show resolved
Hide resolved
mrsladek
reviewed
Nov 12, 2024
...nav/familie/inntektsmelding/refusjonomsorgsdagerarbeidsgiver/rest/SlåOppArbeidstakerDto.java
Outdated
Show resolved
Hide resolved
mrsladek
reviewed
Nov 12, 2024
...tektsmelding/refusjonomsorgsdagerarbeidsgiver/rest/RefusjonOmsorgsdagerArbeidsgiverRest.java
Show resolved
Hide resolved
mrsladek
reviewed
Nov 12, 2024
...tektsmelding/refusjonomsorgsdagerarbeidsgiver/rest/RefusjonOmsorgsdagerArbeidsgiverRest.java
Show resolved
Hide resolved
mrsladek
reviewed
Nov 12, 2024
...familie/inntektsmelding/refusjonomsorgsdagerarbeidsgiver/tjenester/ArbeidstakerTjeneste.java
Outdated
Show resolved
Hide resolved
mrsladek
reviewed
Nov 12, 2024
...familie/inntektsmelding/refusjonomsorgsdagerarbeidsgiver/tjenester/ArbeidstakerTjeneste.java
Show resolved
Hide resolved
selbekk
commented
Nov 14, 2024
src/main/resources/application-prod-gcp-k9saksbehandling.properties
Outdated
Show resolved
Hide resolved
selbekk
force-pushed
the
legg-til-endepunkt-for-oppslag-av-arbeidstaker
branch
2 times, most recently
from
January 13, 2025 13:45
1a0684e
to
cd8b295
Compare
johannbm
reviewed
Jan 14, 2025
src/main/resources/application-dev-gcp-k9saksbehandling.properties
Outdated
Show resolved
Hide resolved
mrsladek
reviewed
Jan 14, 2025
src/main/java/no/nav/familie/inntektsmelding/integrasjoner/aareg/dto/ArbeidsforholdDto.java
Outdated
Show resolved
Hide resolved
mrsladek
reviewed
Jan 14, 2025
...nav/familie/inntektsmelding/refusjonomsorgsdagerarbeidsgiver/rest/SlåOppArbeidstakerDto.java
Outdated
Show resolved
Hide resolved
mrsladek
reviewed
Jan 14, 2025
...milie/inntektsmelding/refusjonomsorgsdagerarbeidsgiver/tjenester/ArbeidsforholdTjeneste.java
Outdated
Show resolved
Hide resolved
selbekk
commented
Jan 14, 2025
...tektsmelding/refusjonomsorgsdagerarbeidsgiver/rest/RefusjonOmsorgsdagerArbeidsgiverRest.java
Show resolved
Hide resolved
mrsladek
reviewed
Jan 14, 2025
src/main/java/no/nav/familie/inntektsmelding/integrasjoner/aareg/AaregRestKlient.java
Outdated
Show resolved
Hide resolved
mrsladek
reviewed
Jan 14, 2025
src/main/java/no/nav/familie/inntektsmelding/integrasjoner/aareg/dto/ArbeidsforholdDto.java
Show resolved
Hide resolved
mrsladek
reviewed
Jan 14, 2025
src/main/resources/application-dev-gcp-k9saksbehandling.properties
Outdated
Show resolved
Hide resolved
mrsladek
reviewed
Jan 14, 2025
src/main/resources/application-dev-gcp-k9saksbehandling.properties
Outdated
Show resolved
Hide resolved
mrsladek
reviewed
Jan 14, 2025
src/main/resources/application-prod-gcp-k9saksbehandling.properties
Outdated
Show resolved
Hide resolved
mrsladek
approved these changes
Jan 14, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Små ting til å fikse - bra jobbet.
Se gjerne på sonarcloud anmerkninger også https://github.com/navikt/ft-inntektsmelding/pull/239/checks?check_run_id=35588952282 |
Jepp, det er litt unødvendige tester, men det var faktisk en litta bug her 😄
Vi ønsker kun nåværende arbeidsforhold.
selbekk
force-pushed
the
legg-til-endepunkt-for-oppslag-av-arbeidstaker
branch
from
January 15, 2025 08:37
940a610
to
8accfa9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Denne PRen legger til et endepunkt for å slå opp en arbeidstaker og arbeidsforholdene deres.
Enn så lenge returnerer den bare dummy-data, så jeg kan fortsette integrasjonen med frontenden. Vet ikke om dere mener det er greit eller ei, så kom gjerne med litt meninger!
Lurer også på om koden burde plasseres der jeg har plassert den, og om den skal ha en egen url eller ikke.