Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Legg til endepunkt for å slå opp arbeidstaker #239

Merged
merged 26 commits into from
Jan 15, 2025

Conversation

selbekk
Copy link
Contributor

@selbekk selbekk commented Nov 12, 2024

Denne PRen legger til et endepunkt for å slå opp en arbeidstaker og arbeidsforholdene deres.

Enn så lenge returnerer den bare dummy-data, så jeg kan fortsette integrasjonen med frontenden. Vet ikke om dere mener det er greit eller ei, så kom gjerne med litt meninger!

Lurer også på om koden burde plasseres der jeg har plassert den, og om den skal ha en egen url eller ikke.

@selbekk selbekk requested review from a team as code owners November 12, 2024 13:43
@selbekk selbekk force-pushed the legg-til-endepunkt-for-oppslag-av-arbeidstaker branch 2 times, most recently from 1a0684e to cd8b295 Compare January 13, 2025 13:45
Copy link
Contributor

@mrsladek mrsladek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Små ting til å fikse - bra jobbet.

@mrsladek
Copy link
Contributor

Se gjerne på sonarcloud anmerkninger også https://github.com/navikt/ft-inntektsmelding/pull/239/checks?check_run_id=35588952282

@selbekk selbekk force-pushed the legg-til-endepunkt-for-oppslag-av-arbeidstaker branch from 940a610 to 8accfa9 Compare January 15, 2025 08:37
@selbekk selbekk merged commit a783840 into master Jan 15, 2025
10 checks passed
@selbekk selbekk deleted the legg-til-endepunkt-for-oppslag-av-arbeidstaker branch January 15, 2025 08:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants