Forsøke å forenkle logikk på forsiden #4812
Open
+258
−322
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Må innrømme jeg mistet lite motet på denne her etterhvert 😅 Men PR sletter flere linjer enn legger til, så burde være en forbedring.
Føler at det burde være flere mulige forbedringer her også. Trenger vi at det finnes både
Sak-type ogEksisterendeSak-type.ValgtBarnogBarn, og mappe mellom DTO-enumer til interne, eksDekningsgradogDekningsgradDTO. Tror kompleksiteten her har sklidd litt ut. Tør ikke ta mer i denne omgang