TOLK-2836 Skill Sync #733
Merged
TOLK-2836 Skill Sync #733
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Domain and Subdomain fields for ServiceResource
permsetGroup and publicGroups Callout interface
EirikFladby
approved these changes
Feb 10, 2025
There was a problem hiding this comment.
Nice! Likte veldig godt Test.loadData(),. Den kan vi få bruk for på andre områder og.
Noen kommentarer:
- Her kan du vel fjerne "this" prefix stort sett overalt bortsett fra i konstruktøren, så blir det litt ryddigere 😄
- Jeg tenker at getterne kunne egentlig bare vært initialisert i en init() som kalles i konstruktøren nå, men getter funker greit det og!
- Vi må oppdatere domain på våre ServiceResources som du sier. Det kan kanskje du gjøre for oss ettersom du har tilgang til det?
Comment on lines
26
to
33
| private Map<Id, User> userMap { | ||
| get { | ||
| if (nksUserMap == null) { | ||
| nksUserMap = new Map<Id, User>(); | ||
| for (User usr : [ | ||
| SELECT Id, Name | ||
| FROM User | ||
| WHERE | ||
| Id IN ( | ||
| SELECT AssigneeId | ||
| FROM PermissionSetAssignment | ||
| WHERE PermissionSetGroup.DeveloperName = 'Kontaktsenter' | ||
| ) | ||
| if (userMap == null) { | ||
| List<User> userList = new List<User>(); | ||
| for (PermissionSetAssignment psa : [ | ||
| SELECT Assignee.Id, Assignee.Name, PermissionSetGroup.DeveloperName | ||
| FROM PermissionSetAssignment | ||
| WHERE PermissionSetGroup.DeveloperName = :this.permsetGroupName |
There was a problem hiding this comment.
Kan ikke dette gjøres direkte om til en map så slipper vi listen?
userMap = new Map<Id, User>([SELECT Id, Name FROM User WHERE Id IN (SELECT AssigneeId osv osv ...
|
EirikFladby
approved these changes
Feb 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix: skill deletion for other than NKS ServiceResources.
Update: set Domain field on ServiceResource creation
Update: check skills only for ServiceResource on given Domain
Added: customization of Domain, Subdomain, PermissionSetGroup, Fotrolig group and Skjermede group for possible sync for other services
Added: Callable interface to make call from independent packages(hot-servicetjenesten)
!IMPORTANT! relevant ServiceResourse´s should be updated to have correct domain. Looks like NKS missing some.
Something like:
List<ServiceResource> srToUpdate = new List>serviceResource>(); for(ServiceResource sr : [SELECT Id, ResourceType, IsActive, CRM_Domain__c, RelatedRecordId, RelatedRecord.Profile.Name, CreatedBy.Name, CreatedDate, LastModifiedDate FROM ServiceResource WHERE RelatedRecordId IN (SELECT AssigneeId FROM PermissionSetAssignment WHERE PermissionSetGroup.DeveloperName = 'Kontaktsenter')]){ sr.CRM_Domain__c = 'NKS'; srToUpdate.add(sr); } update srToUpdate