Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fiks idempotens bug i skedulert hard delete #814

Merged
merged 2 commits into from
Jan 8, 2025
Merged

fiks idempotens bug i skedulert hard delete #814

merged 2 commits into from
Jan 8, 2025

Conversation

kenglxn
Copy link
Contributor

@kenglxn kenglxn commented Jan 6, 2025 •
edited
Loading

Uten denne endringen er det en bug i idempotens som demonstrert i testen.
Denne PRen legger til at SkedulertHardDelete implementerer HardDeletedRepository og legger til en rebuilder som bygger opp deleted_aggregates.

Når denne er ajour i prod så fjernes rebuilder og relatert coroutine som oppdaterer modell.

Fikser:

Partisjon i dev er stuck med dette.

org.postgresql.util.PSQLException: ERROR: insert or update on table "skedulert_hard_delete" violates foreign key constraint "skedulert_hard_delete_aggregate_id_fkey"
  Detail: Key (aggregate_id)=(f6d067e4-7e04-4560-883d-d8cd6230a8b5) is not present in table "aggregate".
	at org.postgresql.core.v3.QueryExecutorImpl.receiveErrorResponse(QueryExecutorImpl.java:2725)
	at org.postgresql.core.v3.QueryExecutorImpl.processResults(QueryExecutorImpl.java:2412)
	at org.postgresql.core.v3.QueryExecutorImpl.execute(QueryExecutorImpl.java:371)
	at org.postgresql.jdbc.PgStatement.executeInternal(PgStatement.java:502)

@kenglxn kenglxn requested a review from a team as a code owner January 6, 2025 19:45
@kenglxn
SkedulertHardDelete implementerer HardDeletedRepository
8466553 
Uten denne endringen er det en bug i idempotens som demonstrert i testen.
Denne PRen legger til at SkedulertHardDelete implementerer HardDeletedRepository og legger til en rebuilder som bygger opp deleted_aggregates.

Når denne er ajour i prod så fjernes rebuilder og relatert coroutine som oppdaterer modell.
@kenglxn kenglxn changed the title WIP: fiks idempotens bug i skedulert hard delete fiks idempotens bug i skedulert hard delete Jan 7, 2025
anderslysne
anderslysne approved these changes Jan 7, 2025
View reviewed changes
Copy link
Contributor

@anderslysne anderslysne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ser flott ut detta :D

@kenglxn kenglxn mentioned this pull request Jan 7, 2025
Merged
1 task
@kenglxn kenglxn merged commit 5f6c064 into main Jan 8, 2025
18 checks passed
@kenglxn kenglxn deleted the fiks_skedulert_hard_delete_idempotens branch January 8, 2025 08:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anderslysne anderslysne anderslysne approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kenglxn @anderslysne