fix: add plugins after flicking is ready

naver · Jun 28, 2024 · 8b8f9e1 · 8b8f9e1
1 parent 66bcb7e
commit 8b8f9e1
Show file tree

Hide file tree

Showing 5 changed files with 22 additions and 22 deletions.
diff --git a/test/unit/Arrow.spec.ts b/test/unit/Arrow.spec.ts
@@ -64,8 +64,8 @@ describe("Arrow", () => {
       it("should interrupt ongoing animation when interruptable is true", async () => {
         // Given
         const plugin = new Arrow({ interruptable: true });
-        flicking.addPlugins(plugin);
         await waitEvent(flicking, "ready");
+        flicking.addPlugins(plugin);
 
         // When
         const nextArrow = flicking.element.querySelector(".flicking-arrow-next");
@@ -82,8 +82,8 @@ describe("Arrow", () => {
       it("should not interrupt ongoing animation when interruptable is true", async () => {
         // Given
         const plugin = new Arrow({ interruptable: false });
-        flicking.addPlugins(plugin);
         await waitEvent(flicking, "ready");
+        flicking.addPlugins(plugin);
 
         // When
         const nextArrow = flicking.element.querySelector(".flicking-arrow-next");

diff --git a/test/unit/AutoPlay.spec.ts b/test/unit/AutoPlay.spec.ts
@@ -23,8 +23,8 @@ describe("AutoPlay", () => {
     const playSpy = sinon.spy(plugin, "play");
 
     // When
-    flicking.addPlugins(plugin);
     await waitEvent(flicking, "ready");
+    flicking.addPlugins(plugin);
 
     // Then
     expect(playSpy.calledOnce).to.be.true;
@@ -39,8 +39,8 @@ describe("AutoPlay", () => {
     nextStub.resolves(void 0);
 
     // When
-    flicking.addPlugins(plugin);
     await waitEvent(flicking, "ready");
+    flicking.addPlugins(plugin);
 
     // Then
     expect(nextStub.called).to.be.false;
@@ -55,8 +55,8 @@ describe("AutoPlay", () => {
     const nextSpy = sinon.spy(flicking, "next");
 
     // When
-    flicking.addPlugins(plugin);
     await waitEvent(flicking, "ready");
+    flicking.addPlugins(plugin);
 
     // Then
     expect(nextSpy.called).to.be.false;
@@ -94,8 +94,8 @@ describe("AutoPlay", () => {
     plugin.stop = stopSpy;
 
     // When
-    flicking.addPlugins(plugin);
     await waitEvent(flicking, "ready");
+    flicking.addPlugins(plugin);
     const wrapper = flicking.element;
 
     // Then
@@ -113,8 +113,8 @@ describe("AutoPlay", () => {
     nextStub.resolves(void 0);
 
     // When
-    flicking.addPlugins(plugin);
     await waitEvent(flicking, "ready");
+    flicking.addPlugins(plugin);
     const wrapper = flicking.element;
 
     // Then
@@ -140,8 +140,8 @@ describe("AutoPlay", () => {
     nextStub.resolves(void 0);
 
     // When
-    flicking.addPlugins(plugin);
     await waitEvent(flicking, "ready");
+    flicking.addPlugins(plugin);
     const wrapper = flicking.element;
 
     // Then
@@ -205,8 +205,8 @@ describe("AutoPlay", () => {
     const flicking = new Flicking(createFlickingFixture());
 
     // When
-    flicking.addPlugins(plugin);
     await waitEvent(flicking, "ready");
+    flicking.addPlugins(plugin);
     const wrapper = flicking.element;
 
     // Then
@@ -245,8 +245,8 @@ describe("AutoPlay", () => {
         easing: x => x,
         duration: 1000
       });
-      flicking.addPlugins(plugin);
       await waitEvent(flicking, "ready");
+      flicking.addPlugins(plugin);
       const flickingWrapper = flicking.element;
 
       await wait(500);

diff --git a/test/unit/Fade.spec.ts b/test/unit/Fade.spec.ts
@@ -29,17 +29,17 @@ describe("Fade", () => {
 
   it("should set opacity to 1 for current panel", async () => {
     // Given & When
-    flicking.addPlugins(new Fade());
     await waitEvent(flicking, "ready");
+    flicking.addPlugins(new Fade());
 
     // Then
     expect(flicking.currentPanel.element.style.opacity).to.equal("1");
   });
 
   it("should apply opacity to child elements if a selector is given", async () => {
     // Given & When
-    flicking.addPlugins(new Fade("p"));
     await waitEvent(flicking, "ready");
+    flicking.addPlugins(new Fade("p"));
 
     // Then
     const currentPanelEl = flicking.currentPanel.element;
@@ -59,8 +59,8 @@ describe("Fade", () => {
 
   it("should be updated whenever flicking moves", async () => {
     // Given
-    flicking.addPlugins(new Fade());
     await waitEvent(flicking, "ready");
+    flicking.addPlugins(new Fade());
 
     // When
     void flicking.moveTo(1, 0);

diff --git a/test/unit/Perspective.spec.ts b/test/unit/Perspective.spec.ts
@@ -27,26 +27,26 @@ describe("Perspective", () => {
 
   it("should set transform to default for current panel", async () => {
     // Given & When
-    flicking.addPlugins(new Perspective());
     await waitEvent(flicking, "ready");
+    flicking.addPlugins(new Perspective());
 
     // Then
     expect(flicking.currentPanel.element.style.transform).to.equal("perspective(1000px) rotateX(0deg) rotateY(0deg) scale(1)");
   });
 
   it("should set transform to default that except perspective for current panel when allocated other arguments", async () => {
     // Given & When
-    flicking.addPlugins(new Perspective({perspective: 500, rotate: 0.5, scale: 0.5}));
     await waitEvent(flicking, "ready");
+    flicking.addPlugins(new Perspective({perspective: 500, rotate: 0.5, scale: 0.5}));
 
     // Then
     expect(flicking.currentPanel.element.style.transform).to.equal("perspective(500px) rotateX(0deg) rotateY(0deg) scale(1)");
   });
 
   it("should apply transform to child elements if a selector is given", async () => {
     // Given & When
-    flicking.addPlugins(new Perspective({selector: "p"}));
     await waitEvent(flicking, "ready");
+    flicking.addPlugins(new Perspective({selector: "p"}));
 
     // Then
     const currentPanelEl = flicking.currentPanel.element;
@@ -66,8 +66,8 @@ describe("Perspective", () => {
 
   it("should be updated whenever flicking moves", async () => {
     // Given
-    flicking.addPlugins(new Perspective());
     await waitEvent(flicking, "ready");
+    flicking.addPlugins(new Perspective());
 
     // When
     void flicking.moveTo(1, 0);

diff --git a/test/unit/Sync.spec.ts b/test/unit/Sync.spec.ts
@@ -48,6 +48,7 @@ describe("Sync", () => {
 
   it("main flicking should move with other flickings", async () => {
     // Given
+    await waitEvent(flicking0, "ready");
     flicking0.addPlugins(new Sync({
       type: "camera",
       synchronizedFlickingOptions: [
@@ -59,7 +60,6 @@ describe("Sync", () => {
         }
       ]
     }));
-    await waitEvent(flicking0, "ready");
 
     // When
     void flicking0.control.moveToPosition(500, 0);
@@ -71,6 +71,7 @@ describe("Sync", () => {
 
   it("other flickings should move main flicking", async () => {
     // Given
+    await waitEvent(flicking1, "ready");
     flicking0.addPlugins(new Sync({
       type: "camera",
       synchronizedFlickingOptions: [
@@ -82,7 +83,6 @@ describe("Sync", () => {
         }
       ]
     }));
-    await waitEvent(flicking1, "ready");
 
     // When
     void flicking1.control.moveToPosition(1100, 0);
@@ -94,6 +94,7 @@ describe("Sync", () => {
 
   it("active panel should have active class", async () => {
     // Given
+    await waitEvent(flicking0, "ready");
     flicking0.addPlugins(new Sync({
       type: "index",
       synchronizedFlickingOptions: [
@@ -107,7 +108,6 @@ describe("Sync", () => {
         }
       ]
     }));
-    await waitEvent(flicking0, "ready");
 
     // When
     void flicking0.moveTo(1, 0);
@@ -121,6 +121,7 @@ describe("Sync", () => {
 
   it("slidable flicking should move other flickings", async () => {
     // Given
+    await waitEvent(flicking0, "ready");
     flicking0.addPlugins(new Sync({
       type: "index",
       synchronizedFlickingOptions: [
@@ -133,7 +134,6 @@ describe("Sync", () => {
         }
       ]
     }));
-    await waitEvent(flicking0, "ready");
 
     // When
     void flicking0.moveTo(2, 0);
@@ -146,6 +146,7 @@ describe("Sync", () => {
 
   it("clickable flicking should move other flickings", async () => {
     // Given
+    await waitEvent(flicking0, "ready");
     flicking0.addPlugins(new Sync({
       type: "index",
       synchronizedFlickingOptions: [
@@ -158,7 +159,6 @@ describe("Sync", () => {
         }
       ]
     }));
-    await waitEvent(flicking0, "ready");
 
     // When
     await simulate(flicking0.panels[2].element, { deltaX: 0, deltaY: 0 });