Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

U/smk4664 add app name #682

Merged
merged 2 commits into from
Jan 23, 2025
Merged

U/smk4664 add app name #682

merged 2 commits into from
Jan 23, 2025

Conversation

smk4664
Copy link
Contributor

@smk4664 smk4664 commented Jan 23, 2025

Closes: #681

What's Changed

Add back in the app_name for urls.py and api/urls.py. Also ensure that these match the module, in this case nautobot_ssot.

To Do

  • Explanation of Change(s)
  • Added change log fragment(s) (for more information see the documentation)
  • Attached Screenshots, Payload Example
  • Unit, Integration Tests
  • Documentation Updates (when adding/changing features)
  • Outline Remaining Work, Constraints from Design

@smk4664
Add back in app_name
feaaa1d 
Turns out that this is useful to have to assist django when url conflicts arise.
@smk4664
Change Fragment
57412a2
@smk4664 smk4664 requested a review from a team as a code owner January 23, 2025 19:06
jdrew82
jdrew82 approved these changes Jan 23, 2025
View reviewed changes
Copy link
Contributor

@jdrew82 jdrew82 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jdrew82 jdrew82 merged commit 7d35242 into develop Jan 23, 2025
15 checks passed
@jdrew82 jdrew82 deleted the u/smk4664-add-app-name branch January 23, 2025 20:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jdrew82 jdrew82 jdrew82 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

App_name for urls
2 participants
@smk4664 @jdrew82