Code

Fix DNAC SSoT Empty Locations#643

Code

Closed

jdrew82 wants to merge 29 commits intodevelopnautobot/nautobot-app-ssot:developfrom patch-635-dna-center-integration-imports-empty-locations-with-meraki-import-disablednautobot/nautobot-app-ssot:patch-635-dna-center-integration-imports-empty-locations-with-meraki-import-disabledCopy head branch name to clipboard

+1,328-1,144

Commits

Commits on Jan 7, 2025

• feat: ✨ Add ability to rename Area if name key found and Building key not found in Location Map.

  jdrew82

  committed
  55ccf0a

  Copy full SHA for 55ccf0a

• refactor: ♻️ Extract determination of device role into own function.

  jdrew82

  committed
  6bc3b28

  Copy full SHA for 6bc3b28

• refactor: ♻️ Refactor build_dnac_location_map to integrate Job location_map.

  jdrew82

  committed
  d7f3c4f

  Copy full SHA for d7f3c4f

• test: ✅ Update tests to adjust for refactor of build_dnac_location_map

  jdrew82

  committed
  da5a089

  Copy full SHA for da5a089

• refactor: ♻️ Refactor Device platform determination into own function.

  jdrew82

  committed
  040db06

  Copy full SHA for 040db06

• refactor: ♻️ Update loading of areas, buildings, and floors to be done from Device POV instead of loading all.

  Show description for 738fcf6
  jdrew82

  committed
  738fcf6

  Copy full SHA for 738fcf6

• test: ✅ Add a test validating load_device_location_tree() when a floor is found.

  jdrew82

  committed
  7596067

  Copy full SHA for 7596067

• test: ✅ Add a test fixture for the expected building_map to use with adapter tests.

  jdrew82

  committed
  1dd3c51

  Copy full SHA for 1dd3c51

• fix: 🐛 Have parent_of_parent for a Building passed to the function to have it used in loading.

  jdrew82

  committed
  e3eba4a

  Copy full SHA for e3eba4a

• style: 🧑‍💻 Add debug logging for DNAC location map

  jdrew82

  committed
  8c896a5

  Copy full SHA for 8c896a5

• refactor: ♻️ Remove area_parent None for load_area as it's unneeded.

  jdrew82

  committed
  5a4adbf

  Copy full SHA for 5a4adbf

• fix: 🐛 Only update name for Floor to include Building name if it's not already in the Floor name.

  jdrew82

  committed
  e2a10aa

  Copy full SHA for e2a10aa

• test: ✅ Add tests validating load_device_location_tree() with and without a floor.

  jdrew82

  committed
  5049675

  Copy full SHA for 5049675

• fix: 🐛 Update floor name when loading a Device to consider if Building name is in the floor name.

  jdrew82

  committed
  f2a5e8d

  Copy full SHA for f2a5e8d

• fix: 🐛 Use dnac_location_map for Floor area_name instead of name from query.

  jdrew82

  committed
  5a3ba52

  Copy full SHA for 5a3ba52

• style: 📝 Tweak logging to include area and area parent names.

  jdrew82

  committed
  d30e2e7

  Copy full SHA for d30e2e7

• refactor: ♻️ Update floors in dnac_location_map to have parent_of_parent if provided in Job location_map.

  jdrew82

  committed
  c522aa0

  Copy full SHA for c522aa0

• refactor: ♻️ Change update of parent and parent_of_parent to happen for both building and area locations.

  jdrew82

  committed
  023de58

  Copy full SHA for 023de58

• fix: 🐛 Update parent_of_parent for building if parent on parent is found.

  jdrew82

  committed
  8fce370

  Copy full SHA for 8fce370

• fix: 🐛 Refactor loading of DNAC location_map to set defaults and then update with Job location_map.

  jdrew82

  committed
  5992cfb

  Copy full SHA for 5992cfb

• test: ✅ Update test to account for change to function

  jdrew82

  committed
  907124d

  Copy full SHA for 907124d

• test: 🚨 Add ignore for pylint

  jdrew82

  committed
  24814e4

  Copy full SHA for 24814e4

• fix: 🐛 Add check for parent_id existing in dnac_location_map

  jdrew82

  committed
  df85eb7

  Copy full SHA for df85eb7

• fix: 🐛 Check for area_id in location_map before using

  jdrew82

  committed
  77309af

  Copy full SHA for 77309af

• test: ✅ Add test fixture for expected locations without Global and update test to use it.

  jdrew82

  committed
  0659e07

  Copy full SHA for 0659e07

• fix: 🐛 Update building name to pull from dnac_location_map

  jdrew82

  committed
  78d5d98

  Copy full SHA for 78d5d98

• test: ✅ Update tests to add missing pieces like id key

  jdrew82

  committed
  cd4981e

  Copy full SHA for cd4981e

• refactor: ♻️ Simplify building of dnac_location_map.

  jdrew82

  committed
  314f479

  Copy full SHA for 314f479

• docs: 📝 Add changelog snippet

  jdrew82

  committed
  fa42e21

  Copy full SHA for fa42e21