Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Catalog V2 #2071

Merged
merged 18 commits into from
Dec 18, 2024
Merged

Catalog V2 #2071

merged 18 commits into from
Dec 18, 2024

Conversation

twitu
Copy link
Collaborator

@twitu twitu commented Nov 24, 2024

Pull Request

Related #2062. The catalog writes data streams to parquet files. This PR ports the logic to Rust and creates pyo3 bindings for it.

  • Write data streams to separate files partitioned by classes
  • Query cataloged data
  • Write data stream to json

Type of change

  • New feature (non-breaking change which adds functionality)

How has this change been tested?

Added and ran new round trip tests

@twitu twitu marked this pull request as ready for review December 8, 2024 05:42
Copy link

codspeed-hq bot commented Dec 18, 2024

CodSpeed Performance Report

Merging #2071 will degrade performances by 44.59%

Comparing catalog-v2 (906af6c) with develop (fcb229d)

Summary

❌ 1 regressions
✅ 51 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark develop catalog-v2 Change
test_condition_none 12.3 µs 22.1 µs -44.59%

@cjdsellers cjdsellers merged commit 0952886 into develop Dec 18, 2024
11 checks passed
@cjdsellers cjdsellers deleted the catalog-v2 branch December 18, 2024 23:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants