Add request_order_book_snapshot method #1745
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
graceyangfan
changed the title
|
Thanks for adding the tests @graceyangfan, much appreciated 🙏. |
cjdsellers
changed the title
|
@cjdsellers In fact, in backtest mode, the request is not doing anything. It only works for live trading at the moment. To make it work in backtest mode, some additional work is still needed. |
|
Yes, for historical requests to work for backtesting the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
#1741 Add request_order_book_snapshot method
Type of change
Delete options that are not relevant.
How has this change been tested?
test with live trading example
Describe how this code was/is tested.