Do not disconnect on NATSReconnectBufferException (#165)

* Do not disconnect on NATSReconnectBufferException and handle all ping exceptions Signed-off-by: Colin Sullivan <[email protected]>
nats-io · Dec 24, 2019 · be92e79 · be92e79
1 parent e70af66
commit be92e79
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 8 deletions.
diff --git a/src/STAN.Client/Options.cs b/src/STAN.Client/Options.cs
@@ -80,9 +80,7 @@ public IConnection NatsConn
         {
             set
             {
-                if(value != null && value.Opts.ReconnectBufferSize != Options.ReconnectBufferDisabled)
-                    throw new ArgumentException("The underlying NATS connection should have buffers during reconnect disabled. E.g controlled via: 'Opts.ReconnectBufferSize = Options.ReconnectBufferDisabled'", nameof(value));
-
+                // TODO:  Override NATS connection buffer settings.
                 natsConn = value;
             }
         }

diff --git a/src/STAN.Client/StanConnection.cs b/src/STAN.Client/StanConnection.cs
@@ -338,7 +338,6 @@ internal Connection(string stanClusterID, string clientID, StanOptions options)
         private void pingServer(object state)
         {
             IConnection conn = null;
-            Exception pingEx = null;
             bool lostConnection = false;
 
             lock (pingLock)
@@ -358,7 +357,6 @@ private void pingServer(object state)
                 if (pingOut > pingMaxOut)
                 {
                     lostConnection = true;
-                    pingEx = new StanMaxPingsException();
                 }
                 else
                 {
@@ -369,7 +367,7 @@ private void pingServer(object state)
 
             if (lostConnection)
             {
-                closeDueToPing(pingEx);
+                closeDueToPing(new StanMaxPingsException());
                 return;
             }
 
@@ -380,11 +378,11 @@ private void pingServer(object state)
             catch (Exception ex)
             when (
                 ex is NATSConnectionClosedException || 
-                ex is NATSStaleConnectionException ||
-                ex is NATSReconnectBufferException)
+                ex is NATSStaleConnectionException)
             {
                 closeDueToPing(ex);
             }
+            catch { /* ignore other publish exceptions */ }
         }
 
         private void closeDueToPing(Exception ex)