FCL 582 Get related documents (e.g. Press Summary for Judgment) #846
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dragon-dxw
force-pushed
the
FCL-582-related-documents-in-api
branch
4 times, most recently
from
b867498 to
b7a4d18
Compare
dragon-dxw
changed the title
dragon-dxw
force-pushed
the
FCL-582-related-documents-in-api
branch
from
b7a4d18 to
b1d72e5
Compare
dragon-dxw
changed the title
dragon-dxw
changed the title
dragon-dxw
force-pushed
the
FCL-582-related-documents-in-api
branch
from
b1d72e5 to
2aa2df1
Compare
|
Open questions: |
dragon-dxw
commented
Jan 31, 2025
dragon-dxw
commented
Jan 31, 2025
| @@ -21,8 +21,10 @@ class IdentifierResolutions(list["IdentifierResolution"]): | |||
| def from_marklogic_output(table: list[str]) -> "IdentifierResolutions": | |||
| return IdentifierResolutions(list(IdentifierResolution.from_marklogic_output(row) for row in table)) | |||
|
|
|||
| def published(self) -> "IdentifierResolutions": | |||
| def published(self, only_published: bool = True) -> "IdentifierResolutions": | |||
There was a problem hiding this comment.
Essentially I think x.published(only_published=only_published) is cleaner than
if only_published:
new_x = x.published()
else:
new_x = x
There was a problem hiding this comment.
I'm confused by what this is trying to achieve; isn't .published always only_published = True?
…ort converting DocURIStrings to MarkLogic ones
dragon-dxw
force-pushed
the
FCL-582-related-documents-in-api
branch
from
17f4241 to
32b9174
Compare
dragon-dxw
changed the title
jacksonj04
approved these changes
Feb 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
https://national-archives.atlassian.net/browse/FCL-582
Checklist