Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AYR-1489 & 1493 - Aria label accessibility changes #767

Merged
merged 1 commit into from
Feb 7, 2025
Merged

AYR-1489 & 1493 - Aria label accessibility changes #767

merged 1 commit into from
Feb 7, 2025

Conversation

ltrasca
Copy link
Collaborator

@ltrasca ltrasca commented Feb 6, 2025

Changes in this PR

  • Added aria labels to search component radios (and slightly modified component structure)
  • Added aria label to series reference filter input inside the transferring body page

JIRA ticket

https://national-archives.atlassian.net/browse/AYR-1493
https://national-archives.atlassian.net/browse/AYR-1489

Screenshots of UI changes

N/A

  • Requires env variable(s) to be updated

@ltrasca ltrasca self-assigned this Feb 6, 2025
anthonyhashemi
anthonyhashemi approved these changes Feb 7, 2025
View reviewed changes
Copy link
Contributor

@anthonyhashemi anthonyhashemi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ltrasca ltrasca merged commit a836786 into main Feb 7, 2025
7 checks passed
@ltrasca ltrasca deleted the AYR-1489/1493/aria-labels branch February 7, 2025 18:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anthonyhashemi anthonyhashemi anthonyhashemi approved these changes

@colinbowen colinbowen Awaiting requested review from colinbowen

Assignees

@ltrasca ltrasca

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ltrasca @anthonyhashemi