forked from cadence-workflow/cadence-go-client
-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Modernize makefile, to make it stable like github.com/uber/cadence (c…
…adence-workflow#1155) Builds now work reliably, even in parallel, and it recovers from previous builds (whether successful or not) without running more than necessary. We should switch to revive and goimports like the server does, and ideally both will move to `go test ./...` eventually (with build tags or something to exclude integration tests) to make the tests run more normally. We can also take advantage of Go's built-in coverage merging and reports that way. But those are for another day. This is just setting a saner foundation. --- At a very high level, this brings the client's makefile in line with the server's, and adds `make build` and `make all` targets for dev-simplicity (and visibility). These targets will do a full build / lint _only when necessary_, i.e. after changes have been made. They should be more than sufficient for most uses, as they now ensure thrift/fmt/copyright headers consistently, but you can run `make lint` to get the output again if desired, and some stages can be run independently without running later ones (like fmt). To see current top-level targets, just run `make`. It'll print help output.
- Loading branch information
Showing
3 changed files
with
304 additions
and
136 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.