feat: add htmlWithOptions
#22
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 310ebcc The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
KiwiKilian
commented
Jan 14, 2024
Comment on lines
+93
to
+95
| if (options?.tailwind) { | ||
| tw(doc); | ||
| } |
There was a problem hiding this comment.
I've only changed this part, otherwise it's just returning the same function as before.
KiwiKilian
commented
Jan 14, 2024
| @@ -8,13 +8,15 @@ Generate a [satori](https://github.com/vercel/satori)-friendly VDOM from a strin | |||
|
|
|||
| Unfortunately, it is built on top of React's JSX and [expects "React-elements-like objects"](https://github.com/vercel/satori#use-without-jsx). This library (`satori-html`) bridges that gap, generating the necessary VDOM object from a string of HTML. | |||
|
|
|||
| > **Note** | |||
| > [!NOTE] | |||
|
@natemoo-re any chance you could have a look at this? Thanks 🙏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I would like to have an option to disable tailwind because when not used it might clash with other class names, see KiwiKilian/eleventy-plugin-og-image#216.
Therefore I've implemented
htmlWithOptions, which could be extended if there shall be more configuration options. I hope it can find a place in the projects scope, otherwise I'm open to any suggestions.