Run UCM Valuation and display results #129
Conversation
…is not used in that module. lucode is used instead. natcap#89
davemfish
changed the title
There was a problem hiding this comment.
Hey @davemfish, I just had two minor comments / questions.
Interesting to see the libraries used in the get_building_footprints script.
| feature.SetField(field_name, field_val) | ||
|
|
||
| layer.SetFeature(feature) |
There was a problem hiding this comment.
I'm not sure if this is necessary but we've typically set layer and vector to None before exiting the function as a precaution to having any hanging files open. I'm not sure if this is still an issue with later versions of GDAL.
There was a problem hiding this comment.
I don't know if it is necessary either. I took this function wholesale from invest, where we're not cleaning them up. But I have pushed a change to clean them up here.
| base_info['projection_wkt'], | ||
| target_proj_wkt | ||
| ) | ||
| print(bbox) |
There was a problem hiding this comment.
Just seeing if it's helpful to keep this print statement here.
There was a problem hiding this comment.
Yes, I think it is. This script is not run in production, it's meant to be run interactively.
This PR links the
ucm_valuation.pymodule with the invest post-processing routines in the worker. Results of valuation are stored alongside other summary statistics from the invest runs.The frontend
Resultscomponent is updated to display a new metric for each scenario:"change in cooling costs" relative to the baseline scenario.