Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[in progress] Fix walletconnect integration #58

Draft
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

kristiehuang
Copy link
Contributor

@kristiehuang kristiehuang commented Nov 29, 2021

  • * Display web3modal to give option to connect to walletconnect
  • * Test walletconnect connect/disconnect on mainnet. Hm. It also does not work smoothly on Rari dapp, which is what this code is forked from.
    • SBAT: connect via walletconnect. On mobile disconnect, should show disconnected on reload. On dapp disconnect, only stays 'disconnected' on dapp but not actually on wallet.
  • not showing ETH balance correctly on walletconnect
  • Test walletconnect connect/disconnect on testnet. Walletconnect x Rainbow on testnet not working lol.... But I think this is Rainbow's fault & not my fault. Rainbow testnet walletconnect also doesn't work on Uniswap either
  • test transaction walletconnect
  • * "Connected to MetaMask/Walletconnect/etc" text update
  • * Disconnect -> Change
  • add walletconnect icon

Screen Shot 2022-01-21 at 12 31 04 AM

@vercel
Copy link

vercel bot commented Nov 29, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/teamyobot/yobot/FpCUiuyiciqDyDUfapr3DsiMk5UA
✅ Preview: https://yobot-git-kh-walletconnect-teamyobot.vercel.app

@kristiehuang kristiehuang marked this pull request as draft November 29, 2021 22:26
@kristiehuang kristiehuang changed the title Fix walletconnect integration [in progress] Fix walletconnect integration Nov 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant