Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[nos3#264] GSW Switch #268

Merged
merged 4 commits into from
Mar 8, 2024
Merged

[nos3#264] GSW Switch #268

merged 4 commits into from
Mar 8, 2024

Conversation

jlucas9
Copy link
Contributor

@jlucas9 jlucas9 commented Mar 7, 2024

Confirmed locally that I'm now able to swap between COSMOS and OpenC3, both running in docker.

Set default to COSMOS for now as it has better performance.

The following PRs much be completed first:

@jlucas9 jlucas9 self-assigned this Mar 7, 2024
@jlucas9 jlucas9 changed the base branch from main to dev March 7, 2024 17:39
@kevincbruce
Copy link
Contributor

Will review shortly. Did WfH in the morning, driving in now. Should I redo/readd some documentation on COSMOS then as well?

@kevincbruce
Copy link
Contributor

@jlucas9 Not sure where it is in the code, but at least on my machine, having pulled and synced everything, I ran into an issue where it seems to prep and launch the docker containers for OpenC3 instead of COSMOS, and the COSMOS GUI never shows up. Can go over it with you tomorrow in a meeting if you want, to see if it's something dumb on my side or something with the PR.

@msuder
Copy link
Contributor

msuder commented Mar 8, 2024

May need to run "make stop-gsw" if OpenC3 is still running since COSMOS has same docker container name. (Check if OpenC3 is running using "docker ps".)

Copy link
Contributor

@msuder msuder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested COSMOS and OpenC3 and both work. Code looks reasonable.

@kevincbruce
Copy link
Contributor

May need to run "make stop-gsw" if OpenC3 is still running since COSMOS has same docker container name. (Check if OpenC3 is running using "docker ps".)

Thanks! That was my issue! Launched COSMOS with 1 satellite, will try with 2 as well, then looks good to me! Will add to tutorial that you need to run make stop-gsw after making after switching GSWs so that you actually switch.

Copy link
Contributor

@kevincbruce kevincbruce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checked, multi-satellite works as well! (everything is on and stays on, just COSMOS doesn't connect to both, and all the 42 Visualizers for SC2 are dead). Performance isn't as terrible either, at least compared to OpenC3 for Multi-Sat.

@jlucas9 jlucas9 merged commit 99430aa into dev Mar 8, 2024
@jlucas9 jlucas9 deleted the nos3#264-gsw-switch branch March 8, 2024 20:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants