HARMONY-1949: Allow None catalog to be passed to service; Remove deprecated code. #52
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… a service and processing messages from SQS queues.
chris-durbin
approved these changes
Nov 11, 2024
There was a problem hiding this comment.
I pushed a couple of additional changes to remove the deprecated usage of SQS queues and the --harmony-action=start command.
I successfully tested with both the harmony-service-example and the new Giovanni time series adapter which does not receive a STAC catalog as input.
indiejames
reviewed
Nov 12, 2024
| The URL that services must POST to when their execution is complete. Services | ||
| should use the `completed_with_*` methods of a Harmony Adapter to perform | ||
| callbacks to ensure compatibility, rather than directly using this URL | ||
| (Deprecated) The URL that services must POST to when their execution is complete. |
There was a problem hiding this comment.
Is there any reason not to drop this field? Is anything still using it? I only see it in tests.
There was a problem hiding this comment.
It requires changes to the data operation schema (affecting the main harmony repo as well). For this PR we're only removing code that can be safely removed without any coordination from other repos required.
indiejames
approved these changes
Nov 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira Issue ID
HARMONY-1949
Description
Allow None catalog to be passed to service; Remove deprecated code.
Local Test Steps
Make a service that takes None catalog and tested locally successfully.
Tested locally with harmony-service-example that is built with the new version of harmony-service-lib-py
PR Acceptance Checklist