-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rename package from harmony
to harmony_service_lib
#45
rename package from harmony
to harmony_service_lib
#45
Conversation
I think it might be worth locally trying to run |
Thanks for implementing this PR! We're trying to figure out the issue Owen is mentioning (and reconciling with Owen's PR). When we merge this in we'll plan to update the major version since it will be a breaking change for everyone. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Successfully tested with harmony-service-example.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested successfully with harmony-service-example locally.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think these changes look functionally great. I used the library locally, and it works nicely. One thing I did spot was a bunch of doc-string comments that are now out of date. I can push a commit up with those now, though.
Thanks @owenlittlejohns, @chris-durbin, @ygliuvt for your help in making this name change happen! |
Jira Issue ID
HARMONY-1781
Description
Change the package name from
harmony
toharmony_service_lib
.Local Test Steps
PR Acceptance Checklist