DAS-1926: Adds common Harmony Message functionality #38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flamingbear
changed the title
chris-durbin
approved these changes
Dec 14, 2023
vinnyinverso
approved these changes
Dec 14, 2023
|
Ugh, sorry I found some tests that Owen wrote that I'm going to add. |
|
@chris-durbin @vinnyinverso Updated tests, coverage is still 100% Just FYI. 9058681 |
indiejames
approved these changes
Dec 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are Harmony Message utility functions that have been copied between services and seem to belong in this harmony-service-lib package.
Jira Issue ID
DAS-1926
Description
This is a simplification / unification of duplicate code that exists in HyBIG and harmony-regridding-service, and I can see it being useful in other services.
This changes nothing to the existing library, just adds functionality that is related to Harmony Message objects, in particular Message.format.
Local Test Steps
Unit tests should pass with:
PR Acceptance Checklist